| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <732aee9c7e895f73f25fbb4bdc97bf5984662a26.camel@codeconstruct.com.au>
Date: Fri, 14 Nov 2025 12:47:55 +1030
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Cosmo Chou <chou.cosmo@...il.com>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
cosmo.chou@...ntatw.com, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, joel@....id.au
Subject: Re: [PATCH v2] ARM: dts: aspeed: bletchley: remove WDTRST1
assertion from wdt1
Hi Cosmo,
On Sat, 2025-10-18 at 12:33 +0800, Cosmo Chou wrote:
> Remove the external signal configuration from wdt1 to prevent the
> WDTRST1 pin from being asserted during watchdog resets.
>
> The WDTRST1 pin was originally configured to reset the TPM during
> watchdog events. However, the pin is incorrectly routed to SRST#
> on the hardware, causing unintended system resets. Since the TPM
> is not currently utilized on this platform, remove the external
> signal configuration to avoid the incorrect reset behavior.
>
> Signed-off-by: Cosmo Chou <chou.cosmo@...il.com>
> ---
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dts | 6 ------
> 1 file changed, 6 deletions(-)
In the process of applying this I was looking at the warnings the
bletchley dts generates. There are quite a few that are devicetree-
specific (i.e. not caused by issues in the SoC DTSI):
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: / (facebook,bletchley-bmc): spi1-gpio: {'compatible': ['spi-gpio'], '#address-cells': 1, '#size-cells': 0, 'gpio-sck': [50, 203, 0], 'gpio-mosi': [50, 204, 0], 'gpio-miso': [50, 205, 0], 'num-chipselects': 1, 'cs-gpios': [[50, 200, 1]], 'tpm@0': {'compatible': ['infineon,slb9670', 'tcg,tpm_tis-spi'], 'spi-max-frequency': 33000000, 'reg': [[0]]}} is not of type 'array'
from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: timer (arm,armv7-timer): 'clocks' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/timer/arm,arch_timer.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: sdram@...e0000 (aspeed,ast2600-sdram-edac): compatible: ['aspeed,ast2600-sdram-edac', 'syscon'] is too long
from schema $id: http://devicetree.org/schemas/edac/aspeed,ast2400-sdram-edac.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: bus@...00000 (aspeed,ast2600-ahbc): compatible: ['aspeed,ast2600-ahbc', 'syscon'] is too long
from schema $id: http://devicetree.org/schemas/bus/aspeed,ast2600-ahbc.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: syscon@...e2000 (aspeed,ast2600-scu): 'smp-memram@...' does not match any of the regexes: '^interrupt-controller@[0-9a-f]+$', '^p2a-control@[0-9a-f]+$', '^pinctrl(@[0-9a-f]+)?$', '^pinctrl-[0-9]+$', '^silicon-id@[0-9a-f]+$'
from schema $id: http://devicetree.org/schemas/mfd/aspeed,ast2x00-scu.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: /ahb/apb/syscon@...e2000/smp-memram@180: failed to match any schema with compatible: ['aspeed,ast2600-smpmem']
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: adc@...e9000 (aspeed,ast2600-adc0): 'interrupts', 'vref' do not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/iio/adc/aspeed,ast2600-adc.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: adc@...e9100 (aspeed,ast2600-adc1): 'interrupts', 'vref' do not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/iio/adc/aspeed,ast2600-adc.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: crypto@...fa000 (aspeed,ast2600-acry): 'aspeed,ahbc' does not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/crypto/aspeed,ast2600-acry.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: /ahb/apb/lpc@...89000/lhc@a0: failed to match any schema with compatible: ['aspeed,ast2600-lhc']
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: /ahb/apb/lpc@...89000/ibt@140: failed to match any schema with compatible: ['aspeed,ast2600-ibt-bmc']
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: pca9539@76 (nxp,pca9539): '#address-cells', '#size-cells' do not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: pca9539@76 (nxp,pca9539): '#address-cells', '#size-cells' do not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: pca9539@76 (nxp,pca9539): '#address-cells', '#size-cells' do not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: pca9539@76 (nxp,pca9539): '#address-cells', '#size-cells' do not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: pca9539@76 (nxp,pca9539): '#address-cells', '#size-cells' do not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: pca9539@76 (nxp,pca9539): '#address-cells', '#size-cells' do not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: i2c@700 (aspeed,ast2600-i2c-bus): Unevaluated properties are not allowed ('aspeed,hw-timeout-ms' was unexpected)
from schema $id: http://devicetree.org/schemas/i2c/aspeed,i2c.yaml#
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: /ahb/apb/dma-controller@...9e000: failed to match any schema with compatible: ['aspeed,ast2600-udma']
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: spi1-gpio (spi-gpio): $nodename:0: 'spi1-gpio' does not match '^spi(@.*|-([0-9]|[1-9][0-9]+))?$'
from schema $id: http://devicetree.org/schemas/spi/spi-gpio.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: spi1-gpio (spi-gpio): gpio-miso: False schema does not allow [50, 205, 0]
from schema $id: http://devicetree.org/schemas/spi/spi-gpio.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: spi1-gpio (spi-gpio): gpio-mosi: False schema does not allow [50, 204, 0]
from schema $id: http://devicetree.org/schemas/spi/spi-gpio.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: spi1-gpio (spi-gpio): gpio-sck: False schema does not allow [50, 203, 0]
from schema $id: http://devicetree.org/schemas/spi/spi-gpio.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: spi1-gpio (spi-gpio): 'sck-gpios' is a required property
from schema $id: http://devicetree.org/schemas/spi/spi-gpio.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: spi1-gpio (spi-gpio): Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'gpio-miso', 'gpio-mosi', 'gpio-sck', 'tpm@0' were unexpected)
from schema $id: http://devicetree.org/schemas/spi/spi-gpio.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: front_gpio_leds (gpio-leds): 'sys_log_id' does not match any of the regexes: '(^led-[0-9a-f]$|led)', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/leds/leds-gpio.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: fan_gpio_leds (gpio-leds): 'fan0_amber', 'fan0_blue', 'fan1_amber', 'fan1_blue', 'fan2_amber', 'fan2_blue', 'fan3_amber', 'fan3_blue' do not match any of the regexes: '(^led-[0-9a-f]$|led)', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/leds/leds-gpio.yaml#
.../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-bletchley.dtb: gpio-keys (gpio-keys): 'presence-sled1', 'presence-sled2', 'presence-sled3', 'presence-sled4', 'presence-sled5', 'presence-sled6' do not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/input/gpio-keys.yaml#
Can you please take some time to address them?
Cheers,
Andrew
Powered by blists - more mailing lists