linux-kernel - Re: [PATCH] perf script: Fix build by removing unused evsel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP-5=fWDMqscf3m3bTog1hMCL6pEjYOsy71Xw7Sbo8inoZE2KQ@mail.gmail.com>
Date: Fri, 14 Nov 2025 08:58:40 -0800
From: Ian Rogers <irogers@...gle.com>
To: James Clark <james.clark@...aro.org>
Cc: linux-perf-users@...r.kernel.org, namhyung@...nel.org, acme@...nel.org, 
	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Adrian Hunter <adrian.hunter@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf script: Fix build by removing unused evsel_script()

On Fri, Nov 14, 2025 at 6:08 AM James Clark <james.clark@...aro.org> wrote:
>
> The evsel_script() function is unused since the linked commit. Fix the
> build by removing it.
>
> Fixes the following compilation error:
>
>   builtin-script.c:347:36: error: unused function 'evsel_script' [-Werror,-Wunused-function]
>   static inline struct evsel_script *evsel_script(struct evsel *evsel)
>                                      ^
> Fixes: 3622990efaab ("perf script: Change metric format to use json metrics")
> Signed-off-by: James Clark <james.clark@...aro.org>

Reviewed-by: Ian Rogers <irogers@...gle.com>

I saw this on clang builds, but didn't get time to dig in. I'm
wondering why GCC wasn't complaining. Anyway.

Thanks,
Ian

> ---
>  tools/perf/builtin-script.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index cf0040bbaba9..581fb101e8be 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -344,11 +344,6 @@ struct evsel_script {
>         u64  samples;
>  };
>
> -static inline struct evsel_script *evsel_script(struct evsel *evsel)
> -{
> -       return (struct evsel_script *)evsel->priv;
> -}
> -
>  static struct evsel_script *evsel_script__new(struct evsel *evsel, struct perf_data *data)
>  {
>         struct evsel_script *es = zalloc(sizeof(*es));
> --
> 2.34.1
>