linux-kernel - Re: [PATCH v3 2/3] Make raw_spin_rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875xbcbdrm.ffs@tglx>
Date: Fri, 14 Nov 2025 20:44:13 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Xie Yuanbin <qq570070308@...il.com>, riel@...riel.com,
 segher@...nel.crashing.org, david@...hat.com, peterz@...radead.org,
 hpa@...or.com, osalvador@...e.de, linux@...linux.org.uk,
 mathieu.desnoyers@...icios.com, paulmck@...nel.org, pjw@...nel.org,
 palmer@...belt.com, aou@...s.berkeley.edu, alex@...ti.fr,
 hca@...ux.ibm.com, gor@...ux.ibm.com, agordeev@...ux.ibm.com,
 borntraeger@...ux.ibm.com, svens@...ux.ibm.com, davem@...emloft.net,
 andreas@...sler.com, luto@...nel.org, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com, acme@...nel.org, namhyung@...nel.org,
 mark.rutland@....com, alexander.shishkin@...ux.intel.com,
 jolsa@...nel.org, irogers@...gle.com, adrian.hunter@...el.com,
 james.clark@...aro.org, anna-maria@...utronix.de, frederic@...nel.org,
 juri.lelli@...hat.com, vincent.guittot@...aro.org,
 dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
 mgorman@...e.de, vschneid@...hat.com, nathan@...nel.org,
 nick.desaulniers+lkml@...il.com, morbo@...gle.com, justinstitt@...gle.com,
 qq570070308@...il.com, thuth@...hat.com, brauner@...nel.org,
 arnd@...db.de, sforshee@...nel.org, mhiramat@...nel.org,
 andrii@...nel.org, oleg@...hat.com, jlayton@...nel.org,
 aalbersh@...hat.com, akpm@...ux-foundation.org, david@...nel.org,
 lorenzo.stoakes@...cle.com, baolin.wang@...ux.alibaba.com,
 max.kellermann@...os.com, ryan.roberts@....com, nysal@...ux.ibm.com,
 urezki@...il.com
Cc: x86@...nel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
 linux-s390@...r.kernel.org, sparclinux@...r.kernel.org,
 linux-perf-users@...r.kernel.org, llvm@...ts.linux.dev, will@...nel.org
Subject: Re: [PATCH v3 2/3] Make raw_spin_rq_unlock inline

On Thu, Nov 13 2025 at 18:52, Xie Yuanbin wrote:

> This function is short, and is called in some critical hot code paths,
> such as finish_lock_switch.
>
> Make it inline to optimize performance.

> +static inline void raw_spin_rq_unlock(struct rq *rq)

That inline does not guarantee that the compiler actually inlines
it. clang is obnoxiously bad at that.