linux-kernel - Re: [RFC PATCH v2 10/12] greybus: cpc: use holding queue instead of sending out immediately

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DE8OIA63YXKK.3VAIFGPTVKZLT@silabs.com>
Date: Fri, 14 Nov 2025 14:53:07 -0500
From: "Yacin Belmihoub-Martel" <yacin.belmihoub-martel@...abs.com>
To: Damien Riégel <damien.riegel@...abs.com>,
        <greybus-dev@...ts.linaro.org>, "Johan Hovold" <johan@...nel.org>,
        "Alex
 Elder" <elder@...nel.org>,
        "Greg Kroah-Hartman"
 <gregkh@...uxfoundation.org>,
        <linux-kernel@...r.kernel.org>
Cc: "Silicon Labs Kernel Team" <linux-devel@...abs.com>
Subject: Re: [RFC PATCH v2 10/12] greybus: cpc: use holding queue instead of
 sending out immediately

On Fri Nov 14, 2025 at 10:07 AM EST, Damien Riégel wrote:
> +/* Write skbs at the head of holding queue */
> +void __cpc_protocol_write_head(struct cpc_cport *cport)

I have a nitpick with the name of this function. I find it misleading,                                                                                                                                             
as it suggests we are writing to the CPort's holding queue head.                                                                                                                                                   
Instead, we are processing the queue to send skbs that fit in the                                                                                                                                                  
remote's RX window (that feature actually comes in another commit).                                                                                                                                                

I propose we rename this API to something along the lines of                                                                                                                                                       
`__cpc_protocol_send_holding_queue` and remove the comment above it.

Thanks,
-- 
Yacin Belmihoub-Martel
Silicon Laboratories