| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20251114195312.22863-12-bhargava.marreddy@broadcom.com>
Date: Sat, 15 Nov 2025 01:22:59 +0530
From: Bhargava Marreddy <bhargava.marreddy@...adcom.com>
To: davem@...emloft.net,
edumazet@...gle.com,
kuba@...nel.org,
pabeni@...hat.com,
andrew+netdev@...n.ch,
horms@...nel.org
Cc: netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
michael.chan@...adcom.com,
pavan.chebbi@...adcom.com,
vsrama-krishna.nemani@...adcom.com,
vikas.gupta@...adcom.com,
Bhargava Marreddy <bhargava.marreddy@...adcom.com>,
Rajashekar Hudumula <rajashekar.hudumula@...adcom.com>
Subject: [v2, net-next 11/12] bng_en: Create per-PF workqueue and timer for asynchronous events
Use a dedicated workqueue and timer for each PF to handle events. This
sets up the infrastructure for the next patch, which will implement the
event handling logic.
Signed-off-by: Bhargava Marreddy <bhargava.marreddy@...adcom.com>
Reviewed-by: Vikas Gupta <vikas.gupta@...adcom.com>
Reviewed-by: Rajashekar Hudumula <rajashekar.hudumula@...adcom.com>
---
drivers/net/ethernet/broadcom/bnge/bnge.h | 10 ++++++
.../net/ethernet/broadcom/bnge/bnge_core.c | 35 ++++++++++++++++++-
.../net/ethernet/broadcom/bnge/bnge_netdev.c | 31 ++++++++++++++++
.../net/ethernet/broadcom/bnge/bnge_netdev.h | 4 +++
4 files changed, 79 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge.h b/drivers/net/ethernet/broadcom/bnge/bnge.h
index 33b42408b1d..88b904246f5 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge.h
+++ b/drivers/net/ethernet/broadcom/bnge/bnge.h
@@ -136,6 +136,7 @@ struct bnge_dev {
unsigned long state;
#define BNGE_STATE_DRV_REGISTERED 0
#define BNGE_STATE_OPEN 1
+#define BNGE_STATE_IN_SP_TASK 2
u64 fw_cap;
@@ -208,9 +209,18 @@ struct bnge_dev {
u8 max_q;
u8 port_count;
+ unsigned int current_interval;
+#define BNGE_TIMER_INTERVAL HZ
+
+ struct timer_list timer;
struct bnge_irq *irq_tbl;
u16 irqs_acquired;
+ struct workqueue_struct *bnge_pf_wq;
+ struct work_struct sp_task;
+ unsigned long sp_event;
+#define BNGE_PERIODIC_STATS_SP_EVENT 0
+
/* To protect link related settings during link changes and
* ethtool settings changes.
*/
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_core.c b/drivers/net/ethernet/broadcom/bnge/bnge_core.c
index 2c72dd34d50..dfa501f912a 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_core.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_core.c
@@ -238,6 +238,23 @@ static int bnge_map_db_bar(struct bnge_dev *bd)
return 0;
}
+static struct workqueue_struct *
+bnge_create_workqueue_thread(struct bnge_dev *bd, char thread_name[])
+{
+ struct workqueue_struct *wq;
+ char *wq_name;
+
+ wq_name = kasprintf(GFP_KERNEL, "%s-%s", thread_name,
+ dev_name(bd->dev));
+ if (!wq_name)
+ return NULL;
+
+ wq = create_singlethread_workqueue(wq_name);
+
+ kfree(wq_name);
+ return wq;
+}
+
static int bnge_probe_one(struct pci_dev *pdev, const struct pci_device_id *ent)
{
unsigned int max_irqs;
@@ -277,6 +294,10 @@ static int bnge_probe_one(struct pci_dev *pdev, const struct pci_device_id *ent)
goto err_devl_free;
}
+ INIT_WORK(&bd->sp_task, bnge_sp_task);
+ timer_setup(&bd->timer, bnge_timer, 0);
+ bd->current_interval = BNGE_TIMER_INTERVAL;
+
rc = bnge_init_hwrm_resources(bd);
if (rc)
goto err_bar_unmap;
@@ -318,14 +339,24 @@ static int bnge_probe_one(struct pci_dev *pdev, const struct pci_device_id *ent)
goto err_config_uninit;
}
+ bd->bnge_pf_wq = bnge_create_workqueue_thread(bd, "bnge_pf_wq");
+ if (!bd->bnge_pf_wq) {
+ dev_err(&pdev->dev, "Unable to create workqueue.\n");
+ rc = -ENOMEM;
+ goto err_free_irq;
+ }
+
rc = bnge_netdev_alloc(bd, max_irqs);
if (rc)
- goto err_free_irq;
+ goto err_free_workq;
pci_save_state(pdev);
return 0;
+err_free_workq:
+ destroy_workqueue(bd->bnge_pf_wq);
+
err_free_irq:
bnge_free_irqs(bd);
@@ -356,6 +387,8 @@ static void bnge_remove_one(struct pci_dev *pdev)
bnge_netdev_free(bd);
+ destroy_workqueue(bd->bnge_pf_wq);
+
bnge_free_irqs(bd);
bnge_net_uninit_dflt_config(bd);
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c
index f00576dd5e0..872c8b6a9be 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c
@@ -253,6 +253,33 @@ static int bnge_alloc_ring_stats(struct bnge_net *bn)
return rc;
}
+void bnge_timer(struct timer_list *t)
+{
+ struct bnge_dev *bd = timer_container_of(bd, t, timer);
+ struct bnge_net *bn = netdev_priv(bd->netdev);
+ struct net_device *dev = bd->netdev;
+
+ if (!netif_running(dev) || !test_bit(BNGE_STATE_OPEN, &bd->state))
+ return;
+
+ if (atomic_read(&bn->intr_sem) != 0)
+ goto bnge_restart_timer;
+
+bnge_restart_timer:
+ mod_timer(&bd->timer, jiffies + bd->current_interval);
+}
+
+void bnge_sp_task(struct work_struct *work)
+{
+ struct bnge_dev *bd = container_of(work, struct bnge_dev, sp_task);
+
+ set_bit(BNGE_STATE_IN_SP_TASK, &bd->state);
+ smp_mb__after_atomic();
+
+ smp_mb__before_atomic();
+ clear_bit(BNGE_STATE_IN_SP_TASK, &bd->state);
+}
+
static void bnge_free_nq_desc_arr(struct bnge_nq_ring_info *nqr)
{
struct bnge_ring_struct *ring = &nqr->ring_struct;
@@ -2111,6 +2138,7 @@ static void bnge_disable_int_sync(struct bnge_net *bn)
struct bnge_dev *bd = bn->bd;
int i;
+ atomic_inc(&bn->intr_sem);
bnge_disable_int(bn);
for (i = 0; i < bd->nq_nr_rings; i++) {
int map_idx = bnge_cp_num_to_irq_num(bn, i);
@@ -2124,6 +2152,7 @@ static void bnge_enable_int(struct bnge_net *bn)
struct bnge_dev *bd = bn->bd;
int i;
+ atomic_set(&bn->intr_sem, 0);
for (i = 0; i < bd->nq_nr_rings; i++) {
struct bnge_napi *bnapi = bn->bnapi[i];
struct bnge_nq_ring_info *nqr = &bnapi->nq_ring;
@@ -2677,6 +2706,7 @@ static int bnge_open_core(struct bnge_net *bn)
bnge_enable_int(bn);
bnge_tx_enable(bn);
+ mod_timer(&bd->timer, jiffies + bd->current_interval);
/* Poll link status and check for SFP+ module status */
mutex_lock(&bd->link_lock);
bnge_get_port_module_status(bn);
@@ -2718,6 +2748,7 @@ static void bnge_close_core(struct bnge_net *bn)
clear_bit(BNGE_STATE_OPEN, &bd->state);
bnge_shutdown_nic(bn);
bnge_disable_napi(bn);
+ timer_delete_sync(&bd->timer);
bnge_free_all_rings_bufs(bn);
bnge_free_irq(bn);
bnge_del_napi(bn);
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h
index 1b66e44c3b9..ad1cfd4e6f0 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h
@@ -350,6 +350,8 @@ struct bnge_net {
struct bnge_ethtool_link_info eth_link_info;
+ atomic_t intr_sem;
+
unsigned long state;
#define BNGE_STATE_NAPI_DISABLED 0
@@ -894,4 +896,6 @@ int bnge_alloc_rx_netmem(struct bnge_net *bn, struct bnge_rx_ring_info *rxr,
void bnge_get_ring_err_stats(struct bnge_net *bn,
struct bnge_total_ring_err_stats *stats);
void bnge_copy_hw_masks(u64 *mask_arr, __le64 *hw_mask_arr, int count);
+void bnge_timer(struct timer_list *t);
+void bnge_sp_task(struct work_struct *work);
#endif /* _BNGE_NETDEV_H_ */
--
2.47.3
Powered by blists - more mailing lists