linux-kernel - Re: [PATCH] x86/bugs: Get rid of the forward declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251114200459.sjh2n6iapyhhmcbx@desk>
Date: Fri, 14 Nov 2025 12:04:59 -0800
From: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>
To: Borislav Petkov <bp@...en8.de>
Cc: Josh Poimboeuf <jpoimboe@...nel.org>,
	"Kaplan, David" <David.Kaplan@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"x86@...nel.org" <x86@...nel.org>,
	"H . Peter Anvin" <hpa@...or.com>, Alexander Graf <graf@...zon.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/bugs: Get rid of the forward declarations

On Fri, Nov 14, 2025 at 06:14:14PM +0100, Borislav Petkov wrote:
> On Wed, Nov 05, 2025 at 09:04:47PM +0100, Borislav Petkov wrote:
> > > We should put cpu_select_mitigations() at the bottom too, then all those
> > > existing forward declarations can go away.
> > 
> > That's a good idea. We should, if it doesn't get too hairy.
> 
> That was easier than I expected. Only build-tested.
> 
> ---
> From: "Borislav Petkov (AMD)" <bp@...en8.de>
> Date: Fri, 14 Nov 2025 18:10:04 +0100
> 
> Get rid of the forward declarations of the mitigation functions by
> moving their single caller below them.
> 
> No functional changes.
> 
> Suggested-by: Josh Poimboeuf <jpoimboe@...nel.org>
> Signed-off-by: Borislav Petkov (AMD) <bp@...en8.de>

Indeed a nice cleanup.

Reviewed-by: Pawan Gupta <pawan.kumar.gupta@...ux.intel.com>