linux-kernel - Re: [PATCH v2 2/2] Fix the source file annotation information for the "FOLL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70d7ef58-8556-4aa4-86c8-b7ed79505471@nvidia.com>
Date: Fri, 14 Nov 2025 12:26:58 -0800
From: John Hubbard <jhubbard@...dia.com>
To: peng8420.li@...il.com, linux-mm@...ck.org, akpm@...ux-foundation.org
Cc: david@...hat.com, osalvador@...e.de, jgg@...pe.ca, peterx@...hat.com,
 linux-kernel@...r.kernel.org, dan.j.williams@...el.com,
 "David Hildenbrand (Red Hat)" <david@...nel.org>
Subject: Re: [PATCH v2 2/2] Fix the source file annotation information for the
 "FOLL_WRITE" macro copied.

On 11/14/25 8:11 AM, peng8420.li@...il.com wrote:
> From: "peng8420.li" <peng8420.li@...il.com>

Please see my reply to patch 1/1, about the real name, and the
From: item too.

> 
> The 'FOLL_RITE' of the copied source is located in mm_types. h of mm, not mm. h, so fix it.

"FOLL_WRITE"

Also, please wrap to 72 columns.

> 
> Suggested-by: "David Hildenbrand (Red Hat)" <david@...nel.org>
> Signed-off-by: peng8420.li <peng8420.li@...il.com>
> ---
>  tools/testing/selftests/mm/gup_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/mm/gup_test.c b/tools/testing/selftests/mm/gup_test.c
> index 75f7134d529d..40c1538a17b4 100644
> --- a/tools/testing/selftests/mm/gup_test.c
> +++ b/tools/testing/selftests/mm/gup_test.c
> @@ -17,7 +17,7 @@
>  
>  #define MB (1UL << 20)
>  
> -/* Just the flags we need, copied from mm.h: */
> +/* Just the flags we need, copied from the kernel internals. */
>  #define FOLL_WRITE	0x01	/* check pte is writable */
>  
>  #define GUP_TEST_FILE "/sys/kernel/debug/gup_test"

With the commit log fixed up, please feel free to add:

Reviewed-by: John Hubbard <jhubbard@...dia.com>

thanks,
-- 
John Hubbard