linux-kernel - [PATCH 1/3] checkpatch: handle variables that begin with 'case'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251114233150.396974-4-ynaffit@google.com>
Date: Fri, 14 Nov 2025 15:31:51 -0800
From: Tiffany Yang <ynaffit@...gle.com>
To: linux-kernel@...r.kernel.org
Cc: kernel-team@...roid.com, Andy Whitcroft <apw@...onical.com>, 
	Joe Perches <joe@...ches.com>, Dwaipayan Ray <dwaipayanray1@...il.com>, 
	Lukas Bulwahn <lukas.bulwahn@...il.com>
Subject: [PATCH 1/3] checkpatch: handle variables that begin with 'case'

The current script returns switch statement-related errors when
variables that start with "case" are used in a ternary.
For example:
    ./scripts/checkpatch.pl --git d1934ed9803c
    ERROR: space prohibited before that ':' (ctx:WxW)
    #289: FILE: drivers/android/tests/binder_alloc_kunit.c:321:
    +				  case_failed ? "FAILED" : "PASSED",
     				                         ^

    ERROR: trailing statements should be on next line
    #289: FILE: drivers/android/tests/binder_alloc_kunit.c:321:
    +				  case_failed ? "FAILED" : "PASSED",

Fix these false positives.

Signed-off-by: Tiffany Yang <ynaffit@...gle.com>
---
 scripts/checkpatch.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 92669904eecc..b026b1235079 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2179,7 +2179,7 @@ sub annotate_values {
 			$av_pending = 'E';
 			$type = 'N';
 
-		} elsif ($cur =~/^(case)/o) {
+		} elsif ($cur =~/^(case)\b/o) {
 			print "CASE($1)\n" if ($dbg_values > 1);
 			$av_pend_colon = 'C';
 			$type = 'N';
@@ -5797,7 +5797,7 @@ sub process {
 				$herecurr);
 		}
 # case and default should not have general statements after them
-		if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g &&
+		if ($line =~ /^.\s*(?:case\b\s*.*|default\s*):/g &&
 		    $line !~ /\G(?:
 			(?:\s*$;*)(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$|
 			\s*return\s+
-- 
2.52.0.rc1.455.g30608eb744-goog