linux-kernel - Re: [PATCH net-next 0/2] Add SQI and SQI+ support for OATC14 10Base-T1S PHYs and Microchip T1S driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fb697284-001d-4433-a05a-d96b335f27c4@microchip.com>
Date: Fri, 14 Nov 2025 05:19:11 +0000
From: <Parthiban.Veerasooran@...rochip.com>
To: <andrew@...n.ch>
CC: <piergiorgio.beruto@...il.com>, <hkallweit1@...il.com>,
	<linux@...linux.org.uk>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 0/2] Add SQI and SQI+ support for OATC14
 10Base-T1S PHYs and Microchip T1S driver

Hi Andrew,

Thank you for reviewing the patches.

On 13/11/25 7:09 pm, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Thu, Nov 13, 2025 at 05:22:04PM +0530, Parthiban Veerasooran wrote:
>> This patch series adds Signal Quality Indicator (SQI) and enhanced SQI+
>> support for OATC14 10Base-T1S PHYs, along with integration into the
>> Microchip T1S PHY driver. These changes enable higher-layer drivers and
>> diagnostic tools to assess link quality more accurately.
> 
> Higher-layer drivers? I don't know of any examples at the moment.  Are
> you thinking of a new bond mode, where it will do active-backup based
> on the best SQI values?
I think I misstated it here. I meant that the higher-layer drivers are 
the OATC14 10Base-T1S PHY drivers, which can use the generic APIs 
implemented in PHYLIB to obtain SQI value. Currently, this patch series 
is intended only for ethtool.

I should have described the patch series more specifically as follows:

This patch series adds Signal Quality Indicator (SQI) and enhanced SQI+ 
support for OATC14 10Base-T1S PHYs, along with integration into the 
Microchip T1S PHY driver. This enables ethtool to report the SQI value 
for OATC14 10Base-T1S PHYs.

If this explanation clarifies things, I will update it in the next version.

Best regards,
Parthiban V
> 
>          Andrew