linux-kernel - Re: [PATCH v2 2/2] ASoC: dt-bindings: ti,tas2781: Add TAS2568/2574/5806M/5806MD/5830 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b863a8f1-22e6-4a52-be8b-9eb83b999937@kernel.org>
Date: Fri, 14 Nov 2025 08:41:08 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Baojun Xu <baojun.xu@...com>, broonie@...nel.org, tiwai@...e.de
Cc: andriy.shevchenko@...ux.intel.com, 13916275206@....com,
 shenghao-ding@...com, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org, lgirdwood@...il.com, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, devicetree@...r.kernel.org,
 k-yi@...com, henry.lo@...com, robinchen@...com, will-wang@...com,
 jim.shil@...rtek.com, toastcheng@...gle.com, chinkaiting@...gle.com
Subject: Re: [PATCH v2 2/2] ASoC: dt-bindings: ti,tas2781: Add
 TAS2568/2574/5806M/5806MD/5830 support

On 14/11/2025 08:33, Baojun Xu wrote:
> TAS5806M, TAS5806MD and TAS5830 is in same family with TAS58XX.
> TAS2568, TAS2574 is in family with TAS257X.
> 
> Signed-off-by: Baojun Xu <baojun.xu@...com>
> 
> ---
> v2:
>  - Add TAS2574 support.
>  - Re-organize the patch, put compatible in front.
>  - Combined some chips as the reg setting is same (0x48-0x4b).

You need to provide reasons for dropping tags.

> ---
>  .../devicetree/bindings/sound/ti,tas2781.yaml | 103 ++++++++++++------
>  1 file changed, 69 insertions(+), 34 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> index f0bb5faf55c8..224999ed6529 100644
> --- a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml
> @@ -34,15 +34,61 @@ description: |
>      https://www.ti.com/lit/gpn/tas2320
>      https://www.ti.com/lit/gpn/tas2563
>      https://www.ti.com/lit/gpn/tas2572
> +    https://www.ti.com/lit/gpn/tas2574
>      https://www.ti.com/lit/gpn/tas2781
> +    https://www.ti.com/lit/gpn/tas5806m
> +    https://www.ti.com/lit/gpn/tas5806md
>      https://www.ti.com/lit/gpn/tas5815
>      https://www.ti.com/lit/gpn/tas5822m
>      https://www.ti.com/lit/gpn/tas5825m
>      https://www.ti.com/lit/gpn/tas5827
>      https://www.ti.com/lit/gpn/tas5828m
> +    https://www.ti.com/lit/gpn/tas5830
>  
>  properties:
>    compatible:
> +    oneOf:
> +      - enum:
> +          - ti,tas2020
> +          - ti,tas2118
> +          - ti,tas2120
> +          - ti,tas2320
> +          - ti,tas2563
> +          - ti,tas2568
> +          - ti,tas2570
> +          - ti,tas2572
> +          - ti,tas2574
> +          - ti,tas2781
> +          - ti,tas5802
> +          - ti,tas5806m
> +          - ti,tas5806md
> +          - ti,tas5815
> +          - ti,tas5822
> +          - ti,tas5825
> +          - ti,tas5827
> +          - ti,tas5828
> +          - ti,tas5830
> +      - items:
> +          - enum:
> +              - ti,tas2020

No, this makes no sense. Device is not both - compatible and not
compatible - at the same time.

Also, rest of my comments were not implemented.

Go back to previous version and read the feedback again. You can reach
to more experienced colleagues in TI who should explain you basics of
upstreaming process. Or listen to one of many speeches/presentations on
upstreaming from conferences or trainings. Or read Linaro's guide on
their blog. It is your homework.

Best regards,
Krzysztof