linux-kernel - Re: [PATCH] fix gpu/drm/nouveau: fix return type in nouveau_dmem_migrate_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f0c742a-3799-42cd-86cf-93ebbc9a3897@kernel.org>
Date: Fri, 14 Nov 2025 09:00:17 +0100
From: "David Hildenbrand (Red Hat)" <david@...nel.org>
To: Balbir Singh <balbirs@...dia.com>, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, dri-devel@...ts.freedesktop.org
Cc: kernel test robot <lkp@...el.com>,
 Andrew Morton <akpm@...ux-foundation.org>, Zi Yan <ziy@...dia.com>,
 Joshua Hahn <joshua.hahnjy@...il.com>, Rakie Kim <rakie.kim@...com>,
 Byungchul Park <byungchul@...com>, Gregory Price <gourry@...rry.net>,
 Ying Huang <ying.huang@...ux.alibaba.com>,
 Alistair Popple <apopple@...dia.com>, Oscar Salvador <osalvador@...e.de>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>,
 "Liam R. Howlett" <Liam.Howlett@...cle.com>, Nico Pache <npache@...hat.com>,
 Ryan Roberts <ryan.roberts@....com>, Dev Jain <dev.jain@....com>,
 Barry Song <baohua@...nel.org>, Lyude Paul <lyude@...hat.com>,
 Danilo Krummrich <dakr@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Ralph Campbell <rcampbell@...dia.com>,
 Mika Penttilä <mpenttil@...hat.com>,
 Matthew Brost <matthew.brost@...el.com>,
 Francois Dugast <francois.dugast@...el.com>
Subject: Re: [PATCH] fix gpu/drm/nouveau: fix return type in
 nouveau_dmem_migrate_to_ram()

On 13.11.25 21:51, Balbir Singh wrote:
> On 11/13/25 22:50, David Hildenbrand (Red Hat) wrote:
>> On 13.11.25 11:31, Balbir Singh wrote:
>>> On 11/13/25 20:09, David Hildenbrand (Red Hat) wrote:
>>>> On 13.11.25 06:13, Balbir Singh wrote:
>>>>> ret of type vm_fault_t is reused to capture the return value of
>>>>> nouveau_dmem_copy_folio(), which returns an int. Use a new copy_ret
>>>>> to fix the issue. The issue is not new, prior to this the function
>>>>> called was called nouveau_dmem_copy_one() and ret was used to capture
>>>>> it's value.
>>>>>
>>>>> Reported-by: kernel test robot <lkp@...el.com>
>>>>> Closes: https://lore.kernel.org/oe-kbuild-all/202511121922.oP20Lzb8-lkp@intel.com/
>>>>
>>>> It's a sparse warning, is there any runtime effect?
>>>>
>>>
>>> No impact really, it's just a sparse warning
>>
>> Okay, then please
>>
>> 1) Make that clear in the patch description
>>
>> 2) Make that clear in the patch subject.
>>
>> In particular, the current subject is weird. Should probably be
>>
>> "nouveau/dmem: fix sparse warning in nouveau_dmem_migrate_to_ram()"
>>
> 
> I did have "sparse warning" in the subject and checkpatch complained that
> tools should not be mentioned in the subject, but I'll give it a shot with that.

The important part is to be careful with the term "fix" when all we're 
fixing is some output of a static code analysis tool that does otherwise 
not result in any actual issues (build time, runtime).

-- 
Cheers

David