linux-kernel - Re: [PATCH v2 0/7] of/fdt: Some bug fixes and cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251114-watchful-sceptical-jerboa-a19d5c@kuoka>
Date: Fri, 14 Nov 2025 09:04:30 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yuntao Wang <yuntao.wang@...ux.dev>
Cc: Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Catalin Marinas <catalin.marinas@....com>, 
	James Morse <james.morse@....com>, Baoquan He <bhe@...hat.com>, 
	Zhen Lei <thunder.leizhen@...wei.com>, Ard Biesheuvel <ardb@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, Geoff Levand <geoff@...radead.org>, 
	Andrew Morton <akpm@...ux-foundation.org>, Changyuan Lyu <changyuanl@...gle.com>, 
	Alexander Graf <graf@...zon.com>, "Mike Rapoport (Microsoft)" <rppt@...nel.org>, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/7] of/fdt: Some bug fixes and cleanups

On Thu, Nov 13, 2025 at 11:50:57PM +0800, Yuntao Wang wrote:
> This patch series fixes several bugs related to dt_root_addr_cells and
> dt_root_size_cells, and performs some cleanup.
> 
> Changelog:
> 
> v1: Consolidate duplicate code into helper functions

Your patchset has multiple checkpatch warnings and errors. In multiple
patches.

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Please run standard kernel tools for static analysis, like coccinelle,
smatch and sparse, and fix reported warnings. Also please check for
warnings when building with W=1 for gcc and clang. Most of these
commands (checks or W=1 build) can build specific targets, like some
directory, to narrow the scope to only your code. The code here looks
like it needs a fix. Feel free to get in touch if the warning is not
clear.

Best regards,
Krzysztof