linux-kernel - Re: [PATCH] pwm: adp5585: correct mismatched pwm chip info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <149fcf8e5df47fd94f9596498e9bfd7171cc7c5c.camel@gmail.com>
Date: Fri, 14 Nov 2025 08:50:12 +0000
From: Nuno Sá <noname.nuno@...il.com>
To: ziniu.wang_1@....com, laurent.pinchart@...asonboard.com, 
	ukleinek@...nel.org, nuno.sa@...log.com, lee@...nel.org
Cc: linux-gpio@...r.kernel.org, linux-pwm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev
Subject: Re: [PATCH] pwm: adp5585: correct mismatched pwm chip info

On Fri, 2025-11-14 at 14:53 +0800, ziniu.wang_1@....com wrote:
> From: Luke Wang <ziniu.wang_1@....com>
> 
> The register addresses of ADP5585 and ADP5589 are reversed.
> 
> Fixes: 75024f97e82e ("pwm: adp5585: add support for adp5589")
> 
> Signed-off-by: Luke Wang <ziniu.wang_1@....com>
> ---

Ouch!

Thanks for the fix!

Acked-by: Nuno Sá <nuno.sa@...log.com>

> 
>  drivers/pwm/pwm-adp5585.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-adp5585.c b/drivers/pwm/pwm-adp5585.c
> index dc2860979e24..806f8d79b0d7 100644
> --- a/drivers/pwm/pwm-adp5585.c
> +++ b/drivers/pwm/pwm-adp5585.c
> @@ -190,13 +190,13 @@ static int adp5585_pwm_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -static const struct adp5585_pwm_chip adp5589_pwm_chip_info = {
> +static const struct adp5585_pwm_chip adp5585_pwm_chip_info = {
>  	.pwm_cfg = ADP5585_PWM_CFG,
>  	.pwm_offt_low = ADP5585_PWM_OFFT_LOW,
>  	.pwm_ont_low = ADP5585_PWM_ONT_LOW,
>  };
>  
> -static const struct adp5585_pwm_chip adp5585_pwm_chip_info = {
> +static const struct adp5585_pwm_chip adp5589_pwm_chip_info = {
>  	.pwm_cfg = ADP5589_PWM_CFG,
>  	.pwm_offt_low = ADP5589_PWM_OFFT_LOW,
>  	.pwm_ont_low = ADP5589_PWM_ONT_LOW,