linux-kernel - Re: [PATCH 2/2] Fix the name of the source file for the "FOLL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0da951c-914c-482a-b5e9-93657b5f7a78@kernel.org>
Date: Fri, 14 Nov 2025 09:57:23 +0100
From: "David Hildenbrand (Red Hat)" <david@...nel.org>
To: peng8420.li@...il.com, linux-mm@...ck.org, akpm@...ux-foundation.org
Cc: osalvador@...e.de, jgg@...pe.ca, jhubbard@...dia.com, peterx@...hat.com,
 linux-kernel@...r.kernel.org, dan.j.williams@...el.com
Subject: Re: [PATCH 2/2] Fix the name of the source file for the "FOLL_WRITE"
 macro copy

On 14.11.25 09:50, peng8420.li@...il.com wrote:
> From: "peng8420.li" <peng8420.li@...il.com>
> 
> The 'FOLL_RITE' of the copied source is located in mm_types. h of mm, not mm. h, so fix it.
> 
> Signed-off-by: peng8420.li <peng8420.li@...il.com>
> ---
>   tools/testing/selftests/mm/gup_test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/mm/gup_test.c b/tools/testing/selftests/mm/gup_test.c
> index 75f7134d529d..9cdcd10d3f6a 100644
> --- a/tools/testing/selftests/mm/gup_test.c
> +++ b/tools/testing/selftests/mm/gup_test.c
> @@ -17,7 +17,7 @@
>   
>   #define MB (1UL << 20)
>   
> -/* Just the flags we need, copied from mm.h: */
> +/* Just the flags we need, copied from mm_types.h: */

Can we just avoid the exact name and say "Just the flags we need, copied 
from the kernel internals."

?

-- 
Cheers

David