linux-kernel - Re: [PATCH] net: ethernet: broadcom: replace strcpy with strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRbxSCXsWCar8tw8@fedora>
Date: Fri, 14 Nov 2025 14:37:20 +0530
From: ShiHao <i.shihao.999@...il.com>
To: David Laight <david.laight.linux@...il.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	i.shihao.999@...il.com, kuba@...nel.org,
	linux-kernel@...r.kernel.org, mchan@...adcom.com,
	netdev@...r.kernel.org, pabeni@...hat.com,
	pavan.chebbi@...adcom.com
Subject: Re: [PATCH] net: ethernet: broadcom: replace strcpy with strscpy

On Thu, Nov 13, 2025 at 07:22:18PM +0000, David Laight wrote:

> No one really knows that TG3_BPN_SIZE is in any way related to the destination.
> So this doesn't actually make the code that much better at all.
>
> Since tp->board_part_number is an array and "BCM5717" a constant I suspect
> there is already a compile-time check that the string fits.
> The strcpy() will also be converted to a memcpy().
>
> So all, in all, this makes the code worse on several fronts.
>
> 	Davidi


Okay. I got it thanks for your time david.