linux-kernel - Re: [PATCH] gpu/drm/nouveau: fix return type in nouveau_dmem_migrate_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e118987c-431c-4152-89d1-563f1312a574@nvidia.com>
Date: Fri, 14 Nov 2025 20:13:58 +1100
From: Balbir Singh <balbirs@...dia.com>
To: "David Hildenbrand (Red Hat)" <david@...nel.org>,
 linux-kernel@...r.kernel.org, linux-mm@...ck.org,
 dri-devel@...ts.freedesktop.org
Cc: kernel test robot <lkp@...el.com>,
 Andrew Morton <akpm@...ux-foundation.org>, Zi Yan <ziy@...dia.com>,
 Joshua Hahn <joshua.hahnjy@...il.com>, Rakie Kim <rakie.kim@...com>,
 Byungchul Park <byungchul@...com>, Gregory Price <gourry@...rry.net>,
 Ying Huang <ying.huang@...ux.alibaba.com>,
 Alistair Popple <apopple@...dia.com>, Oscar Salvador <osalvador@...e.de>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>,
 "Liam R. Howlett" <Liam.Howlett@...cle.com>, Nico Pache <npache@...hat.com>,
 Ryan Roberts <ryan.roberts@....com>, Dev Jain <dev.jain@....com>,
 Barry Song <baohua@...nel.org>, Lyude Paul <lyude@...hat.com>,
 Danilo Krummrich <dakr@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Ralph Campbell <rcampbell@...dia.com>,
 Mika Penttilä <mpenttil@...hat.com>,
 Matthew Brost <matthew.brost@...el.com>,
 Francois Dugast <francois.dugast@...el.com>
Subject: Re: [PATCH] gpu/drm/nouveau: fix return type in
 nouveau_dmem_migrate_to_ram()

On 11/14/25 19:33, David Hildenbrand (Red Hat) wrote:
> On 14.11.25 02:22, Balbir Singh wrote:
>> ret of type vm_fault_t is reused to capture the return value of
>> nouveau_dmem_copy_folio(), which returns an int. Use a new variable
>> err to fix the issue. The issue is not new, prior to this the function
>> called was called nouveau_dmem_copy_one() and ret was used to capture
>> it's value.
>>
>> The bug does not cause a real issue at runtime, the value is used
>> as a boolean to check if nouveau_dmem_copy_folio() succeeded or failed.
>> The different types should not impact the execution of the code at
>> runtime.
>>
> 
> Also, as commented previously, the prefix in the subject does not match existing norms. Take a look at
> 
>     git log --oneline drivers/gpu/drm/nouveau/nouveau_dmem.c
> 
> and note how it's commonly something along the lines of "drm/nouveau" or better "drm/nouveau/dmem".
> 
> The only patch that uses "gpu/drm/nouveau" is from you recently. In fact, there is no other patch in the codebase that uses that prefix.
> 

I'll fix the subject prefix

Thanks for the review,
Balbir