linux-kernel - Re: [PATCH v2] watchdog: bd96081: Fix a spelling mistake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b31f5017-eb85-43a6-99f3-5eabc21841ad@gmail.com>
Date: Fri, 14 Nov 2025 11:17:02 +0200
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Chu Guangqing <chuguangqing@...pur.com>, wim@...ux-watchdog.org,
 linux@...ck-us.net
Cc: linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] watchdog: bd96081: Fix a spelling mistake

Hi Chu!

Thanks for the fix!

Hm. I suppose I missed the v1. I agree with Guenter that a change log 
would be nice. Then I knew what was in v1 without looking for it.



On 14/11/2025 04:05, Chu Guangqing wrote:
> The spelling of the word "initializate" is incorrect; the correct spelling is
> "initialize".
> 
> Signed-off-by: Chu Guangqing <chuguangqing@...pur.com>
> ---
>   drivers/watchdog/bd96801_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/bd96801_wdt.c b/drivers/watchdog/bd96801_wdt.c
> index 12b74fd2bc05..43ec23c53e62 100644
> --- a/drivers/watchdog/bd96801_wdt.c
> +++ b/drivers/watchdog/bd96801_wdt.c
> @@ -370,7 +370,7 @@ static int bd96801_wdt_probe(struct platform_device *pdev)
>   
>   		set_bit(WDOG_HW_RUNNING, &w->wdt.status);
>   	} else {
> -		/* If WDG is not running so we will initializate it */
> +		/* If WDG is not running so we will initialize it */

I think it would be even better if the 'so' was dropped. And, as a 
matter of fact, I am not sure the comment serves any real purpose here. 
The code pretty much says it already. So, I am OK with either dropping 
the 'so' as well, or the whole comment.

With that:
Reviewed-by: Matti Vaittinen <mazziesaccount@...il.com>

>   		ret = init_wdg_hw(w);
>   		if (ret)
>   			return ret;
Yours,
	-- Matti

---
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~