linux-kernel - Re: [PATCH v6 8/8] ARM: dts: r9a06g032: Add support for GPIO interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdULa3Myv5M13mZnBfGRfpnCasRbDFSFsh-Yji+Gw3gycA@mail.gmail.com>
Date: Fri, 14 Nov 2025 10:37:40 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: "Herve Codina (Schneider Electric)" <herve.codina@...tlin.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Wolfram Sang <wsa+renesas@...g-engineering.com>, 
	Hoan Tran <hoan@...amperecomputing.com>, Linus Walleij <linus.walleij@...aro.org>, 
	Bartosz Golaszewski <brgl@...ev.pl>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Magnus Damm <magnus.damm@...il.com>, Saravana Kannan <saravanak@...gle.com>, 
	Serge Semin <fancer.lancer@...il.com>, Phil Edworthy <phil.edworthy@...esas.com>, 
	linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	Pascal Eberhard <pascal.eberhard@...com>, Miquel Raynal <miquel.raynal@...tlin.com>, 
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v6 8/8] ARM: dts: r9a06g032: Add support for GPIO interrupts

Hi Hervé,

On Mon, 27 Oct 2025 at 13:36, Herve Codina (Schneider Electric)
<herve.codina@...tlin.com> wrote:
> In the RZ/N1 SoC, the GPIO interrupts are multiplexed using the GPIO
> Interrupt Multiplexer.
>
> Add the multiplexer node and connect GPIO interrupt lines to the
> multiplexer.
>
> The interrupt-map available in the multiplexer node has to be updated in
> dts files depending on the GPIO usage. Indeed, the usage of an interrupt
> for a GPIO is board dependent.
>
> Up to 8 GPIOs can be used as an interrupt line (one per multiplexer
> output interrupt).
>
> Signed-off-by: Herve Codina (Schneider Electric) <herve.codina@...tlin.com>
> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>

Thanks for your patch!

> --- a/arch/arm/boot/dts/renesas/r9a06g032.dtsi
> +++ b/arch/arm/boot/dts/renesas/r9a06g032.dtsi
> @@ -534,6 +534,14 @@ gpio0a: gpio-port@0 {
>                                 #gpio-cells = <2>;
>                                 snps,nr-gpios = <32>;
>                                 reg = <0>;
> +
> +                               interrupt-controller;
> +                               interrupt-parent = <&gpioirqmux>;
> +                               interrupts = < 0  1  2  3  4  5  6  7
> +                                              8  9 10 11 12 13 14 15
> +                                             16 17 18 19 20 21 22 23
> +                                             24 25 26 27 28 29 30 31 >;

I would drop the spaces after/before the angle brackets.

> +                               #interrupt-cells = <2>;
>                         };
>
>                         /* GPIO0b[0..1]   connected to pins GPIO1..2   */

> @@ -620,6 +644,23 @@ gpio2b: gpio-port@1 {
>                         };
>                 };
>
> +               gpioirqmux: interrupt-controller@...00480 {
> +                       compatible = "renesas,r9a06g032-gpioirqmux", "renesas,rzn1-gpioirqmux";
> +                       reg = <0x51000480 0x20>;
> +                       #interrupt-cells = <1>;
> +                       #address-cells = <0>;
> +                       interrupt-map-mask = <0x7f>;
> +
> +                       /*
> +                        * Example mapping entry. Board DTs need to overwrite
> +                        * 'interrupt-map' with their specific mapping. Check
> +                        * the irqmux binding documentation for details.
> +                        */
> +                       interrupt-map = <0 &gic GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
> +
> +                       status = "disabled";

So this is disabled by default (despite the driver being enabled by
default), because the board has to provide the proper real interrupt-map
anyway.  Makes sense.

> +               };
> +
>                 can0: can@...04000 {
>                         compatible = "renesas,r9a06g032-sja1000", "renesas,rzn1-sja1000";
>                         reg = <0x52104000 0x800>;

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds