linux-kernel - Re: [PATCH v4 01/14] cxl/region: Store root decoder in struct cxl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRb4fGKjjpJDwMTx@rric.localdomain>
Date: Fri, 14 Nov 2025 10:38:04 +0100
From: Robert Richter <rrichter@....com>
To: Jonathan Cameron <jonathan.cameron@...wei.com>,
	Alejandro Lucero Palau <alucerop@....com>
Cc: Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Davidlohr Bueso <dave@...olabs.net>, linux-cxl@...r.kernel.org,
	linux-kernel@...r.kernel.org, Gregory Price <gourry@...rry.net>,
	"Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com>,
	Terry Bowman <terry.bowman@....com>,
	Joshua Hahn <joshua.hahnjy@...il.com>,
	alejandro.lucero-palau@....com
Subject: Re: [PATCH v4 01/14] cxl/region: Store root decoder in struct
 cxl_region

On 11.11.25 14:45:41, Jonathan Cameron wrote:
> On Mon, 3 Nov 2025 19:47:42 +0100
> Robert Richter <rrichter@....com> wrote:
> 
> > A region is always bound to a root decoder. The region's associated
> > root decoder is often needed. Add it to struct cxl_region.
> > 
> > This simplifies the code by removing dynamic lookups and the root
> > decoder argument from the function argument list where possible.
> > 
> > Patch is a prerequisite to implement address translation which uses
> > struct cxl_region to store all relevant region and interleaving
> > parameters. It changes the argument list of __construct_region() in
> > preparation of adding a context argument. Additionally the arg list of
> > cxl_region_attach_position() is simplified and the use of
> > to_cxl_root_decoder() removed, which always reconstructs and checks
> > the pointer. The pointer never changes and is frequently used. Code
> > becomes more readable as this amphazises the binding between both
> > objects.
> > 
> > Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> > Reviewed-by: Jonathan Cameron <jonathan.cameron@...wei.com>
> > Reviewed-by: Gregory Price <gourry@...rry.net>
> > Signed-off-by: Robert Richter <rrichter@....com>
> 
> Just a note to say this will (maybe just context) clash with Alejandro's rework
> around construct_region_begin()
> 
> https://lore.kernel.org/all/20251110153657.2706192-19-alejandro.lucero-palau@amd.com/
> 
> Probably easy to resolve, but worth both of you being aware if you hadn't noticed
> already!

I have checked the conflicts and they look trivial. There are no
"functional" conflicts.

Thanks for pointing out.

-Robert