linux-kernel - Re: [PATCH v1 1/1] PCI: stm32-ep: Don't use "proxy" headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ba695c7d-32fa-4412-9029-26d9a0e73b11@foss.st.com>
Date: Fri, 14 Nov 2025 10:37:20 +0100
From: Christian Bruel <christian.bruel@...s.st.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        <linux-pci@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
CC: Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kwilczynski@...nel.org>,
        "Manivannan
 Sadhasivam" <mani@...nel.org>,
        Rob Herring <robh@...nel.org>, Bjorn Helgaas
	<bhelgaas@...gle.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        "Alexandre Torgue" <alexandre.torgue@...s.st.com>
Subject: Re: [PATCH v1 1/1] PCI: stm32-ep: Don't use "proxy" headers

Hello,

On 11/12/25 09:56, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
> 
> In this case replace of_gpio.h, which is subject to remove by the GPIOLIB
> subsystem, with the respective headers that are being used by the driver.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/pci/controller/dwc/pcie-stm32-ep.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-stm32-ep.c b/drivers/pci/controller/dwc/pcie-stm32-ep.c
> index 3400c7cd2d88..2b9b451306fc 100644
> --- a/drivers/pci/controller/dwc/pcie-stm32-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-stm32-ep.c
> @@ -7,9 +7,9 @@
>    */
>   
>   #include <linux/clk.h>
> +#include <linux/gpio/consumer.h>
>   #include <linux/mfd/syscon.h>
>   #include <linux/of_platform.h>
> -#include <linux/of_gpio.h>
>   #include <linux/phy/phy.h>
>   #include <linux/platform_device.h>
>   #include <linux/pm_runtime.h>

<linux/gpio/consumer.h> is already included from pcie-designware.h

However, if it is still required for IWYU, could you kindly include it 
in pcie-stm32.c as well while you are working on it?

Thank you very much

Christian