linux-kernel - Re: [PATCH v2 1/1] lib/vsprintf: Deduplicate special hex number specifier data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRb6S_JjJ5oslKCP@pathway.suse.cz>
Date: Fri, 14 Nov 2025 10:45:47 +0100
From: Petr Mladek <pmladek@...e.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2 1/1] lib/vsprintf: Deduplicate special hex number
 specifier data

On Thu 2025-11-13 16:02:59, Andy Shevchenko wrote:
> Two functions use the same specifier data for the special hex number.
> Almost the same as the field width is calculated on the size of the
> given type. Due to that, make a compound literal macro in order to
> deduplicate the rest.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Looks good to me:

Reviewed-by: Petr Mladek <pmladek@...e.com>
Tested-by: Petr Mladek <pmladek@...e.com>

I am going to wait few more days for potential feedback and push
it next Wednesday or so if nobody complained.

Best Regards,
Petr