linux-kernel - Re: [PATCH 3/4 v3] PCI: s32g: Add initial PCIe support (RC)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b945e463-52ec-417c-8e6a-599c35a6727d@foss.st.com>
Date: Fri, 14 Nov 2025 11:05:45 +0100
From: Christian Bruel <christian.bruel@...s.st.com>
To: Manivannan Sadhasivam <mani@...nel.org>,
        Bjorn Helgaas
	<helgaas@...nel.org>
CC: Vincent Guittot <vincent.guittot@...aro.org>, <chester62515@...il.com>,
        <mbrugger@...e.com>, <ghennadi.procopciuc@....nxp.com>, <s32@....com>,
        <bhelgaas@...gle.com>, <jingoohan1@...il.com>, <lpieralisi@...nel.org>,
        <kwilczynski@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <Ionut.Vicovan@....com>,
        <larisa.grigore@....com>, <Ghennadi.Procopciuc@....com>,
        <ciprianmarian.costea@....com>, <bogdan.hamciuc@....com>,
        <Frank.li@....com>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-pci@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <imx@...ts.linux.dev>,
        <cassel@...nel.org>, Richard Zhu
	<hongxing.zhu@....com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Minghuan Lian
	<minghuan.Lian@....com>,
        Mingkai Hu <mingkai.hu@....com>, Roy Zang
	<roy.zang@....com>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH 3/4 v3] PCI: s32g: Add initial PCIe support (RC)


>>
>> The implication is that *every* user of dw_pcie_suspend_noirq() would
>> have to check for the link being up.  There are only three existing
>> callers:
>>
>>    imx_pcie_suspend_noirq()
>>    ls_pcie_suspend_noirq()
>>    stm32_pcie_suspend_noirq()
>>
>> but none of them checks for the link being up.
>>

stm32 supports L1.1, so we bail out before pme_turn_off() in 
dw_pcie_suspend_noirq()

> 
> If no devices are attached to the bus, then there is no need to broadcast
> PME_Turn_Off and wait for L2/L3. I've just sent out a series that fixes it [1].
> Hopefully, this will allow Vincent to use dw_pcie_{suspend/resume}_noirq() APIs.
> 
> - Mani
> 
> [1] https://lore.kernel.org/linux-pci/20251106061326.8241-1-manivannan.sadhasivam@oss.qualcomm.com/

dw_pcie_suspend_noirq() path tested OK on stm32mp2.

Regards

Christian