linux-kernel - Re: [PATCH v3 3/5] pwm: Add rockchip PWMv4 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9941350.lOV4Wx5bFT@workhorse>
Date: Fri, 14 Nov 2025 11:13:29 +0100
From: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
To: Damon Ding <damon.ding@...k-chips.com>,
 Uwe Kleine-König <ukleinek@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
 Lee Jones <lee@...nel.org>, William Breathitt Gray <wbg@...nel.org>,
 kernel@...labora.com, Jonas Karlman <jonas@...boo.se>,
 Alexey Charkov <alchark@...il.com>, linux-rockchip@...ts.infradead.org,
 linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-iio@...r.kernel.org
Subject: Re: [PATCH v3 3/5] pwm: Add rockchip PWMv4 driver

On Friday, 14 November 2025 10:51:27 Central European Standard Time you wrote:
> On Tue, Oct 28, 2025 at 04:16:26PM +0800, Damon Ding wrote:
> > Hi Nicolas,
> > 
> > On 10/28/2025 1:11 AM, Nicolas Frattaroli wrote:
> > > [...]
> > > 
> > 
> > Tested-by: Damon Ding <damon.ding@...k-chips.com>
> > 
> > I have tested all the PWM channels in continuous mode on my RK3576-IOTEST
> > board.
> > 
> > Test commands are like:
> > 
> > cd /sys/class/pwm/pwmchip0/
> > echo 0 > export
> > cd pwm0
> > echo 10000 > period
> > echo 5000 > duty_cycle
> > echo normal > polarity
> > echo 1 > enable
> 
> Thanks for the test, very appreciated.
> 
> I wonder what made you test using sysfs instead of
> https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/libpwm.git/.
> Is it unknown? Too complicated? Other problems?

Can't speak for Damon Ding but this is the first time I've heard of
libpwm, so I think you do need to market it better. :) Perhaps by
mentioning it in the PWM subsystem docs as a way to interface with
the kernel, if that's permitted by the docs people. (It should be,
since libiio is mentioned for IIO.)

Kind regards,
Nicolas Frattaroli

> 
> Best regards
> Uwe
>