linux-kernel - Re: [PATCH v2 0/6] crypto/hwrng: Simplify with of_device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRcC7NzNk7__6hb3@gondor.apana.org.au>
Date: Fri, 14 Nov 2025 18:22:36 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Olivia Mackall <olivia@...enic.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
	Jesper Nilsson <jesper.nilsson@...s.com>,
	Lars Persson <lars.persson@...s.com>,
	"David S. Miller" <davem@...emloft.net>,
	Tom Lendacky <thomas.lendacky@....com>,
	John Allen <john.allen@....com>,
	Srujana Challa <schalla@...vell.com>,
	Bharat Bhushan <bbhushan2@...vell.com>,
	linux-crypto@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...s.com
Subject: Re: [PATCH v2 0/6] crypto/hwrng: Simplify with
 of_device_get_match_data()

On Fri, Nov 07, 2025 at 09:15:47AM +0100, Krzysztof Kozlowski wrote:
> Changes in v2:
> - crypto: artpec6: Add missing (enum artpec6_crypto_variant) cast (to
>   fix 32-bit builds)
> - Add Acks/Rb tags.
> - Link to v1: https://patch.msgid.link/20251106-crypto-of-match-v1-0-36b26cd35cff@linaro.org
> 
> Few simple cleanups, not tested on the hardware.
> 
> Care has to be taken when converting of_match_data() into
> of_device_get_match_data(), because first can check arbitrary
> device_node and the latter checks device's node.  Cases here should be
> safe because of_match_data() uses 'dev.of_node'.
> 
> Best regards,
> Krzysztof
> 
> ---
> Krzysztof Kozlowski (6):
>       hwrng: bcm2835 - Move MODULE_DEVICE_TABLE() to table definition
>       hwrng: bcm2835 - Simplify with of_device_get_match_data()
>       crypto: artpec6 - Simplify with of_device_get_match_data()
>       crypto: ccp - Constify 'dev_vdata' member
>       crypto: ccp - Simplify with of_device_get_match_data()
>       crypto: cesa - Simplify with of_device_get_match_data()
> 
>  drivers/char/hw_random/bcm2835-rng.c | 11 +++--------
>  drivers/crypto/axis/artpec6_crypto.c |  9 +++------
>  drivers/crypto/ccp/sp-dev.h          |  2 +-
>  drivers/crypto/ccp/sp-platform.c     | 17 +++--------------
>  drivers/crypto/marvell/cesa/cesa.c   |  7 ++-----
>  5 files changed, 12 insertions(+), 34 deletions(-)
> ---
> base-commit: cec65c58b74636b6410fc766be1ca89247fbc68e
> change-id: 20251106-crypto-of-match-22726ffd20b4
> 
> Best regards,
> -- 
> Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt