linux-kernel - RE: [PATCH 1/4] dt-bindings: spi: aspeed,ast2600-fmc: Add AST2700 SoC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TYZPR06MB52031D72CBC176D38A71EB12B2CAA@TYZPR06MB5203.apcprd06.prod.outlook.com>
Date: Fri, 14 Nov 2025 00:57:23 +0000
From: Chin-Ting Kuo <chin-ting_kuo@...eedtech.com>
To: Conor Dooley <conor@...nel.org>
CC: "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"joel@....id.au" <joel@....id.au>, "andrew@...econstruct.com.au"
	<andrew@...econstruct.com.au>, "clg@...d.org" <clg@...d.org>,
	"clg@...hat.com" <clg@...hat.com>, "broonie@...nel.org" <broonie@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "openbmc@...ts.ozlabs.org"
	<openbmc@...ts.ozlabs.org>, "linux-spi@...r.kernel.org"
	<linux-spi@...r.kernel.org>, BMC-SW <BMC-SW@...eedtech.com>
Subject: RE: [PATCH 1/4] dt-bindings: spi: aspeed,ast2600-fmc: Add AST2700 SoC
 support

Hi Conor,

Thanks for the review.

> -----Original Message-----
> From: Conor Dooley <conor@...nel.org>
> Sent: Friday, November 14, 2025 3:36 AM
> Subject: Re: [PATCH 1/4] dt-bindings: spi: aspeed,ast2600-fmc: Add AST2700
> SoC support
> 
> On Thu, Nov 13, 2025 at 04:53:29PM +0800, Chin-Ting Kuo wrote:
> > Add AST2700 to the list of supported SoCs in the ASPEED FMC/SPI bindings.
> 
> Please add information here as to why these devices are not compatible with
> the ast2600 ones. With that info,
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> pw-bot: changes-requested
> 

Okay, some differences between AST2600 and AST2700 will be described in the next patch version.

> >
> > Signed-off-by: Chin-Ting Kuo <chin-ting_kuo@...eedtech.com>
> > ---
> >  Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml | 4
> > +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml
> > b/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml
> > index 57d932af4506..80e542624cc6 100644
> > --- a/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml
> > +++ b/Documentation/devicetree/bindings/spi/aspeed,ast2600-fmc.yaml
> > @@ -12,7 +12,7 @@ maintainers:
> >
> >  description: |
> >    This binding describes the Aspeed Static Memory Controllers (FMC
> > and
> > -  SPI) of the AST2400, AST2500 and AST2600 SOCs.
> > +  SPI) of the AST2400, AST2500, AST2600 and AST2700 SOCs.
> >
> >  allOf:
> >    - $ref: spi-controller.yaml#
> > @@ -20,6 +20,8 @@ allOf:
> >  properties:
> >    compatible:
> >      enum:
> > +      - aspeed,ast2700-fmc
> > +      - aspeed,ast2700-spi
> >        - aspeed,ast2600-fmc
> >        - aspeed,ast2600-spi
> >        - aspeed,ast2500-fmc
> > --
> > 2.34.1
> >