linux-kernel - Re: [PATCH] pwm: adp5585: correct mismatched pwm chip info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <umvpvqkbv2w7cqg533xpvira66qdxqa2bjpnzymeic72st42qb@6f7bgychfrzw>
Date: Fri, 14 Nov 2025 12:03:34 +0100
From: Uwe Kleine-König <ukleinek@...nel.org>
To: Nuno Sá <noname.nuno@...il.com>
Cc: ziniu.wang_1@....com, laurent.pinchart@...asonboard.com, 
	nuno.sa@...log.com, lee@...nel.org, linux-gpio@...r.kernel.org, 
	linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org, imx@...ts.linux.dev
Subject: Re: [PATCH] pwm: adp5585: correct mismatched pwm chip info

Hello Nuno,

On Fri, Nov 14, 2025 at 09:46:43AM +0000, Nuno Sá wrote:
> On Fri, 2025-11-14 at 10:30 +0100, Uwe Kleine-König wrote:
> > On Fri, Nov 14, 2025 at 02:53:08PM +0800, ziniu.wang_1@....com wrote:
> > > From: Luke Wang <ziniu.wang_1@....com>
> > > 
> > > The register addresses of ADP5585 and ADP5589 are reversed.
> > 
> > My German feeling for the English language suggests:
> > s/reversed/swapped/.

I applied this substitution and dropped the empty line between Fixes:
and the first Signed-off-by: line.

> > I wonder how that didn't pop up during development of 75024f97e82e. I
> > would expect that the driver doesn't work correctly in a very obvious
> > way without this change?! I tend to want to send this to Linus before
> > 6.18, but the question makes me wonder if I'm correct with that
> > urgency. Any insights?
> 
> Yeah, this one I kind of asked for Liu to test it (as I was not testing the PWM bits)
> and he did tested it [2]. But it was v2 and that series had some more iterations. So
> I suspect that I messed up along the way and the last version of the series was not
> tested (for the PWM bits).
> 
> [2]: https://lore.kernel.org/linux-gpio/3efb68e2-7091-47e1-81a2-39930da5a427@nxp.com/

OK, so I guess it is sensible to get it into 6.18. I applied it for
next (i.e.

	https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next

) and will send it to Linus mid next week in the assumption that no
issues pop up.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)