linux-kernel - Re: [PATCH 1/2] wifi: ath: Use static calibration variant table for devicetree platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9d47593-6fba-495e-aedb-c0efcaa5526e@kernel.org>
Date: Fri, 14 Nov 2025 12:24:38 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@....qualcomm.com>
Cc: srinivas.kandagatla@....qualcomm.com, Jeff Johnson <jjohnson@...nel.org>,
 Johannes Berg <johannes@...solutions.net>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-wireless@...r.kernel.org,
 linux-kernel@...r.kernel.org, ath10k@...ts.infradead.org,
 ath11k@...ts.infradead.org, devicetree@...r.kernel.org,
 ath12k@...ts.infradead.org, Miaoqing Pan <miaoqing.pan@....qualcomm.com>
Subject: Re: [PATCH 1/2] wifi: ath: Use static calibration variant table for
 devicetree platforms

On 14/11/2025 12:16, Manivannan Sadhasivam wrote:
>>>  
>>> +static const struct __ath_calib_variant_table {
>>> +	const char *machine;
>>> +	const char *variant;
>>> +} ath_calib_variant_table[] = {
>>> +	{ "ALFA Network AP120C-AC", "ALFA-Network-AP120C-AC" },
>>> +	{ "8devices Jalapeno", "8devices-Jalapeno" },
>>> +	{ "Google cozmo board", "GO_COZMO" },
>>> +	{ "Google damu board", "GO_DAMU" },
>>> +	{ "Google fennel sku1 board", "GO_FENNEL" },
>>> +	{ "Google fennel sku6 board", "GO_FENNEL" },
>>> +	{ "Google fennel sku7 board", "GO_FENNEL" },
>>
>> Are these top-machine models? If so, you cannot use them. The value is
>> user-informative, not ABI. If you wanted to use them, you would need to
>> document the ABI.
>>
> 
> I had this question initially, but Srini convinced me it is OK to use it in the
> driver as they do it in audio :)

That's sounds like an issue which could be fixed or at least discussed.
There is no in-kernel usage of ASoC's 'model' property, thus we probably
never noticed that it is an ABI.

OTOH, everyone apparently knows that audio's 'model' is an ABI because
no one changes it, unlike top-level machine 'model' which is being
changed from time to time.

Best regards,
Krzysztof