linux-kernel - Re: [PATCH v6 1/2] audit: add audit_log_nf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAABTaaBceDLf2XSEi8H=2_swcoAk0oj8smOPyFkPWud2QzVnsg@mail.gmail.com>
Date: Fri, 14 Nov 2025 08:45:11 -0300
From: Ricardo Robaina <rrobaina@...hat.com>
To: kernel test robot <lkp@...el.com>
Cc: audit@...r.kernel.org, linux-kernel@...r.kernel.org, 
	netfilter-devel@...r.kernel.org, coreteam@...filter.org, 
	oe-kbuild-all@...ts.linux.dev, paul@...l-moore.com, eparis@...hat.com, 
	fw@...len.de, pablo@...filter.org, kadlec@...filter.org
Subject: Re: [PATCH v6 1/2] audit: add audit_log_nf_skb helper function

Dear reviewers,

I missed that unused variable, please disregard this version. I'm
submitting an updated one right away.

On Fri, Nov 14, 2025 at 3:48 AM kernel test robot <lkp@...el.com> wrote:
>
> Hi Ricardo,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on pcmoore-audit/next]
> [also build test WARNING on netfilter-nf/main nf-next/master linus/master v6.18-rc5 next-20251113]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Ricardo-Robaina/audit-include-source-and-destination-ports-to-NETFILTER_PKT/20251113-223721
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git next
> patch link:    https://lore.kernel.org/r/589b485078a65c766bcdee2fd9881c540813f8c5.1763036807.git.rrobaina%40redhat.com
> patch subject: [PATCH v6 1/2] audit: add audit_log_nf_skb helper function
> config: arm-randconfig-002-20251114 (https://download.01.org/0day-ci/archive/20251114/202511141355.QCbxBTw0-lkp@intel.com/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 14.3.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251114/202511141355.QCbxBTw0-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202511141355.QCbxBTw0-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
>    net/netfilter/xt_AUDIT.c: In function 'audit_tg':
> >> net/netfilter/xt_AUDIT.c:35:13: warning: unused variable 'fam' [-Wunused-variable]
>       35 |         int fam = -1;
>          |             ^~~
>
>
> vim +/fam +35 net/netfilter/xt_AUDIT.c
>
> 43f393caec0362a Thomas Graf        2011-01-16  30
> 43f393caec0362a Thomas Graf        2011-01-16  31  static unsigned int
> 43f393caec0362a Thomas Graf        2011-01-16  32  audit_tg(struct sk_buff *skb, const struct xt_action_param *par)
> 43f393caec0362a Thomas Graf        2011-01-16  33  {
> 43f393caec0362a Thomas Graf        2011-01-16  34       struct audit_buffer *ab;
> 2173c519d5e912a Richard Guy Briggs 2017-05-02 @35       int fam = -1;
> 43f393caec0362a Thomas Graf        2011-01-16  36
> f7859590d976148 Richard Guy Briggs 2018-06-05  37       if (audit_enabled == AUDIT_OFF)
> ed018fa4dfc3d26 Gao feng           2013-03-04  38               goto errout;
> 43f393caec0362a Thomas Graf        2011-01-16  39       ab = audit_log_start(NULL, GFP_ATOMIC, AUDIT_NETFILTER_PKT);
> 43f393caec0362a Thomas Graf        2011-01-16  40       if (ab == NULL)
> 43f393caec0362a Thomas Graf        2011-01-16  41               goto errout;
> 43f393caec0362a Thomas Graf        2011-01-16  42
> 43f393caec0362a Thomas Graf        2011-01-16  43       audit_log_format(ab, "mark=%#x", skb->mark);
> 43f393caec0362a Thomas Graf        2011-01-16  44
> 832662a8b1d3d70 Ricardo Robaina    2025-11-13  45       audit_log_nf_skb(ab, skb, xt_family(par));
> 131ad62d8fc06d9 Mr Dash Four       2011-06-30  46
> 43f393caec0362a Thomas Graf        2011-01-16  47       audit_log_end(ab);
> 43f393caec0362a Thomas Graf        2011-01-16  48
> 43f393caec0362a Thomas Graf        2011-01-16  49  errout:
> 43f393caec0362a Thomas Graf        2011-01-16  50       return XT_CONTINUE;
> 43f393caec0362a Thomas Graf        2011-01-16  51  }
> 43f393caec0362a Thomas Graf        2011-01-16  52
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>