linux-kernel - Re: [PATCH] net: phy: fix doc for rgii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0437ae6c-b2ec-4883-90a2-d83d280f9f34@gocontroll.com>
Date: Fri, 14 Nov 2025 12:54:15 +0100
From: Maud Spierings <maudspierings@...ontroll.com>
To: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 Russell King <linux@...linux.org.uk>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: fix doc for rgii_clock()

forgot to add fixes tag, if it is needed it is:

Fixes: 91695b859263 ("net: phy: improve rgmii_clock() documentation")

Kind regards,
Maud

On 11/14/25 12:39, Maud Spierings via B4 Relay wrote:
> From: Maud Spierings <maudspierings@...ontroll.com>
> 
> The doc states that the clock values also apply to the rmii mode,
> "as the clock rates are identical". But as far as I can find the
> clock rate for rmii is 50M at both 10 and 100 mbits/s [1].
> 
> Link: https://en.wikipedia.org/wiki/Media-independent_interface [1]
> 
> Signed-off-by: Maud Spierings <maudspierings@...ontroll.com>
> ---
> This patch is also part question, I am working on an imx8mp based device
> with the dwmac-imx driver. In imx_dwmac_set_clk_tx_rate() and
> imx_dwmac_fix_speed() both rmii and mii are excluded from setting the
> clock rate with this function.
> 
> But from what I can read only rmii should be excluded, I am not very
> knowledgable with regards to networkinging stuff so my info is
> coming from wikipedia.
> 
> I am adding this exclusion to the barebox bootloader, but I am not sure
> if I should also be excluding mii as is being done upstream.
> ---
>   include/linux/phy.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/phy.h b/include/linux/phy.h
> index bf5457341ca8..e941b280c196 100644
> --- a/include/linux/phy.h
> +++ b/include/linux/phy.h
> @@ -296,9 +296,9 @@ static inline const char *phy_modes(phy_interface_t interface)
>    * @speed: link speed value
>    *
>    * Description: maps RGMII supported link speeds into the clock rates.
> - * This can also be used for MII, GMII, and RMII interface modes as the
> - * clock rates are identical, but the caller must be aware that errors
> - * for unsupported clock rates will not be signalled.
> + * This can also be used for MII and GMII interface modes as the clock rates
> + * are identical, but the caller must be aware that errors for unsupported
> + * clock rates will not be signalled.
>    *
>    * Returns: clock rate or negative errno
>    */
> 
> ---
> base-commit: 0f2995693867bfb26197b117cd55624ddc57582f
> change-id: 20251114-rgmii_clock-1389d0667bf7
> 
> Best regards,