linux-kernel - Re: [PATCH v2] ksmbd: server: avoid busy polling in accept loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRcaOZ79iQwqMTZI@horms.kernel.org>
Date: Fri, 14 Nov 2025 12:02:01 +0000
From: Simon Horman <horms@...nel.org>
To: Qingfang Deng <dqfext@...il.com>
Cc: Namjae Jeon <linkinjeon@...nel.org>, Steve French <smfrench@...il.com>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Tom Talpey <tom@...pey.com>, Hyunchul Lee <hyc.lee@...il.com>,
	Ronnie Sahlberg <lsahlber@...hat.com>, linux-cifs@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	Stefan Metzmacher <metze@...ba.org>
Subject: Re: [PATCH v2] ksmbd: server: avoid busy polling in accept loop

On Tue, Nov 11, 2025 at 06:47:49PM +0800, Qingfang Deng wrote:

...

> @@ -458,10 +451,6 @@ static void tcp_destroy_socket(struct socket *ksmbd_socket)
>  	if (!ksmbd_socket)
>  		return;
>  
> -	/* set zero to timeout */
> -	ksmbd_tcp_rcv_timeout(ksmbd_socket, 0);
> -	ksmbd_tcp_snd_timeout(ksmbd_socket, 0);
> -

Hi Qingfang Deng,

W=1 builds tell me that ksmbd_tcp_rcv_timeout() is now unused:
I expect it can be removed.

>  	ret = kernel_sock_shutdown(ksmbd_socket, SHUT_RDWR);
>  	if (ret)
>  		pr_err("Failed to shutdown socket: %d\n", ret);

...