linux-kernel - Re: [PATCH v2] ASoC: qcom: sdm845: set quaternary MI2S codec DAI to I2S format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <789ca70c-c9ac-4290-8a24-1f83febe498f@kernel.org>
Date: Fri, 14 Nov 2025 12:33:11 +0000
From: Srinivas Kandagatla <srini@...nel.org>
To: david@...t.cz, Srinivas Kandagatla <srini@...nel.org>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>
Cc: linux-sound@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org, phone-devel@...r.kernel.org,
 "Dr. Git" <drgitx@...il.com>, Casey Connolly <casey.connolly@...aro.org>
Subject: Re: [PATCH v2] ASoC: qcom: sdm845: set quaternary MI2S codec DAI to
 I2S format

On 11/14/25 12:14 AM, David Heidelberg via B4 Relay wrote:
> From: "Dr. Git" <drgitx@...il.com>
> 
> We configure the codec DAI format for primary and secondary but not the
> quaternery MI2S path. Add the missing configuration to enable speaker
> codecs on the quaternary MI2S like the MAX9827 found on the OnePlus 6.
> 
> Signed-off-by: Dr. Git <drgitx@...il.com>

Please fix your git user.name, looks like "Dr. Git" is not your real name.

Other than that patch itself looks sane to me.

--srini

> Signed-off-by: Casey Connolly <casey.connolly@...aro.org>
> Signed-off-by: David Heidelberg <david@...t.cz>
> ---
> Changes in v2:
>  - Rebased on top of next-20251113
> ---
>  sound/soc/qcom/sdm845.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/qcom/sdm845.c b/sound/soc/qcom/sdm845.c
> index e18a8e44f2db5..0ce9dff4dc525 100644
> --- a/sound/soc/qcom/sdm845.c
> +++ b/sound/soc/qcom/sdm845.c
> @@ -365,10 +365,12 @@ static int sdm845_snd_startup(struct snd_pcm_substream *substream)
>  		snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
>  		break;
>  	case QUATERNARY_MI2S_RX:
> +		codec_dai_fmt |= SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_I2S;
>  		snd_soc_dai_set_sysclk(cpu_dai,
>  			Q6AFE_LPASS_CLK_ID_QUAD_MI2S_IBIT,
>  			MI2S_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
>  		snd_soc_dai_set_fmt(cpu_dai, fmt);
> +		snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
>  		break;
>  
>  	case QUATERNARY_TDM_RX_0:
> 
> ---
> base-commit: 6d7e7251d03f98f26f2ee0dfd21bb0a0480a2178
> change-id: 20251114-sdm845-quaternary-e9d6d0b513c9
> 
> Best regards,