linux-kernel - Re: [PATCH v2 2/2] arm64: dts: rockchip: Add Asus Tinker Board 3 and 3S device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <24561990-8293-0505-5837-eca416d01bb7@manjaro.org>
Date: Sat, 15 Nov 2025 08:14:58 +0100
From: "Dragan Simic" <dsimic@...jaro.org>
To: "Michael Opdenacker" <michael.opdenacker@...tcommit.com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, heiko@...ech.de, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add Asus Tinker Board 3 and 3S device tree

Hello Michael,

On Saturday, November 15, 2025 07:03 CET, Michael Opdenacker <michael.opdenacker@...tcommit.com> wrote:
> On 11/15/25 01:53, Dragan Simic wrote:
> > Thanks for the v2!  Please, see one nitpick below.
> >
> > On Friday, November 14, 2025 16:46 CET, michael.opdenacker@...tcommit.com wrote:
> >> From: Michael Opdenacker <michael.opdenacker@...tcommit.com>
> > I'm sorry for not mentioning it in my earlier responses, but this
> > line is redundant, because it duplicates the From value found in
> > the actual email message.
> 
> This actually comes from my Git settings. I need this when I send 
> patches to the Yocto project and OpenEmbedded. That's because their 
> mailing list server which alters the address of senders ("<sender> via 
> lists.yoctoproject.org"), and ultimately the commit author identity in 
> Git. See 
> https://docs.yoctoproject.org/contributor-guide/submit-changes.html#fixing-your-from-identity
> 
> I've checked that my patches apply fine and that this "From:" line 
> doesn't appear in the commits in the tree.
> So, can I keep this?

Actually, I forgot to mention that the From headers in your patch
submissions are a bit wrong by containing just the email address,
without the first and last name.  That issue should be fixed first,
regardless of the presence (or absence) of From tags.

Thanks for clarifying what's the reason for having the From tags
regardless of the actual need for having them.  Maybe setting Git's
"format.from" option to true at the repository level could solve
this nicely, while also exercising the Git-fu a bit? :)

BTW, my responses are currently jailed by the linux-rockchip mailing
list, requiring manual approval, as a result of the mail server I'm
using sometimes inserting some strange invisible UTF-8 characters
into the email subjects.  Oh well. :)