linux-kernel - Re: [PATCH v7 1/2] smb: move CREATE_DURABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd-EwaXmNViyUQMgPb-bPfpUPuoSQ+6GWdbqA5nZ-6Z97g@mail.gmail.com>
Date: Sat, 15 Nov 2025 16:45:45 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: chenxiaosong.chenxiaosong@...ux.dev
Cc: sfrench@...ba.org, smfrench@...il.com, linkinjeon@...ba.org, 
	christophe.jaillet@...adoo.fr, linux-cifs@...r.kernel.org, 
	linux-kernel@...r.kernel.org, chenxiaosong@...nxiaosong.com, 
	ChenXiaoSong <chenxiaosong@...inos.cn>
Subject: Re: [PATCH v7 1/2] smb: move CREATE_DURABLE_RECONN to common/smb2pdu.h

On Thu, Nov 13, 2025 at 10:34 PM <chenxiaosong.chenxiaosong@...ux.dev> wrote:
>
> From: ChenXiaoSong <chenxiaosong@...inos.cn>
>
> The fields in struct create_durable_reconn_req and struct create_durable
> are exactly the same, so remove create_durable_reconn_req from server,
> and use typedef to define both CREATE_DURABLE_REQ and CREATE_DURABLE_RECONN
> for a single struct.
>
> Rename the following places:
>
>   - struct create_durable -> CREATE_DURABLE_REQ
>   - struct create_durable_reconn_req -> CREATE_DURABLE_RECONN
>
> The documentation references are:
>
>   - SMB2_CREATE_DURABLE_HANDLE_REQUEST   in MS-SMB2 2.2.13.2.3
>   - SMB2_CREATE_DURABLE_HANDLE_RECONNECT in MS-SMB2 2.2.13.2.4
>   - SMB2_FILEID in MS-SMB2 2.2.14.1
>
> Descriptions of the struct fields:
>
>   - __u8  Reserved[16]: DurableRequest field of SMB2_CREATE_DURABLE_HANDLE_REQUEST.
>                         A 16-byte field that MUST be reserved.
>   - __u64 PersistentFileId: Persistent field of 2.2.14.1 SMB2_FILEID
>   - __u64 VolatileFileId: Volatile field of 2.2.14.1 SMB2_FILEID
>   - struct Fid: Data field of SMB2_CREATE_DURABLE_HANDLE_RECONNECT.
>                 An SMB2_FILEID structure, as specified in section 2.2.14.1.
>
> Suggested-by: Namjae Jeon <linkinjeon@...nel.org>
> Signed-off-by: ChenXiaoSong <chenxiaosong@...inos.cn>
I have changed struct names like the following ones and applied it to
#ksmbd-for-next-next.
 - struct create_durable -> create_durable_req_t
 - struct create_durable_reconn_req -> create_durable_reconn_t
Thanks!