linux-kernel - Re: [PATCH v8 5/6] gpu: nova-core: add boot42 support for next-gen GPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5db58446-f79e-4674-8cea-9f31034adfca@nvidia.com>
Date: Fri, 14 Nov 2025 16:10:38 -0800
From: John Hubbard <jhubbard@...dia.com>
To: Alexandre Courbot <acourbot@...dia.com>,
 Danilo Krummrich <dakr@...nel.org>
Cc: Joel Fernandes <joelagnelf@...dia.com>, Timur Tabi <ttabi@...dia.com>,
 Alistair Popple <apopple@...dia.com>, Edwin Peer <epeer@...dia.com>,
 Zhi Wang <zhiw@...dia.com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
 nouveau@...ts.freedesktop.org, rust-for-linux@...r.kernel.org,
 LKML <linux-kernel@...r.kernel.org>,
 Nouveau <nouveau-bounces@...ts.freedesktop.org>
Subject: Re: [PATCH v8 5/6] gpu: nova-core: add boot42 support for next-gen
 GPUs

On 11/14/25 6:01 AM, Alexandre Courbot wrote:
> On Fri Nov 14, 2025 at 11:41 AM JST, John Hubbard wrote:
> <snip>
>> +register!(NV_PMC_BOOT_42 @ 0x00000a00, "Extended architecture information" {
>> +    15:12   minor_revision as u8, "Minor revision of the chip";
>> +    19:16   major_revision as u8, "Major revision of the chip";
>> +    23:20   implementation as u8, "Implementation version of the architecture";
>> +    29:24   architecture as u8 ?=> Architecture, "Architecture value";
>> +});
>>  
>> -    /// Combines `architecture` and `implementation` to obtain a code unique to the chipset.
> 
> This comment for the `chipset` method got deleted. Is there a reason? If not I'll restore it when applying.

Ah yes. It got deleted because NV_PMC_BOOT_0::chipset() also got deleted.
And then, I didn't add a corresponding comment for NV_PMC_BOOT_42::chipset().

I'll add it. I have to respin anyway. Thanks for catching it!


thanks,
-- 
John Hubbard