linux-kernel - Re: [PATCH net-next v2 2/3] net: stmmac: Add glue driver for Motorcomm YT6801 ethernet controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRhjtPbO0ElkBM26@pie>
Date: Sat, 15 Nov 2025 11:27:48 +0000
From: Yao Zi <ziyao@...root.org>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Frank <Frank.Sae@...or-comm.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Vladimir Oltean <vladimir.oltean@....com>,
	Choong Yong Liang <yong.liang.choong@...ux.intel.com>,
	Chen-Yu Tsai <wens@...e.org>, Jisheng Zhang <jszhang@...nel.org>,
	Furong Xu <0x1207@...il.com>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, Mingcong Bai <jeffbai@...c.io>,
	Runhua He <hua@...c.io>, Xi Ruoyao <xry111@...111.site>
Subject: Re: [PATCH net-next v2 2/3] net: stmmac: Add glue driver for
 Motorcomm YT6801 ethernet controller

On Tue, Nov 11, 2025 at 11:07:24AM +0000, Russell King (Oracle) wrote:
> On Tue, Nov 11, 2025 at 10:52:51AM +0000, Yao Zi wrote:
> > +	plat->bus_id		= pci_dev_id(pdev);
> > +	plat->phy_addr		= -1;
> > +	plat->phy_interface	= PHY_INTERFACE_MODE_GMII;
> > +	plat->clk_csr		= STMMAC_CSR_20_35M;
> > +	plat->tx_coe		= 1;
> > +	plat->rx_coe		= 1;
> > +	plat->maxmtu		= JUMBO_LEN;
> > +	plat->rx_queues_to_use	= 1;
> > +	plat->tx_queues_to_use	= 1;
> > +	plat->clk_ref_rate	= 125000000;
> > +	plat->core_type		= DWMAC_CORE_GMAC4;
> > +	plat->suspend		= stmmac_pci_plat_suspend;
> > +	plat->resume		= motorcomm_resume;
> > +	plat->flags		= STMMAC_FLAG_TSO_EN;
> 
> Can you also set STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP here, so if EEE
> is used, we can shut down the transmit clock to the PHY if the PHY
> supports that? I would like all new glue drivers to set this where
> possible please.

Yes, the flag could be set and I'll do it in v3.

Regards,
Yao Zi

> Thanks.
> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!