linux-kernel - Re: [PATCH v2 0/7] of/fdt: Some bug fixes and cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251115140700.182265-1-yuntao.wang@linux.dev>
Date: Sat, 15 Nov 2025 22:07:00 +0800
From: Yuntao Wang <yuntao.wang@...ux.dev>
To: krzk@...nel.org
Cc: akpm@...ux-foundation.org,
	ardb@...nel.org,
	bhe@...hat.com,
	catalin.marinas@....com,
	changyuanl@...gle.com,
	devicetree@...r.kernel.org,
	geert+renesas@...der.be,
	geoff@...radead.org,
	graf@...zon.com,
	james.morse@....com,
	linux-kernel@...r.kernel.org,
	mark.rutland@....com,
	robh@...nel.org,
	rppt@...nel.org,
	saravanak@...gle.com,
	thunder.leizhen@...wei.com,
	yuntao.wang@...ux.dev
Subject: Re: [PATCH v2 0/7] of/fdt: Some bug fixes and cleanups

On Fri, 14 Nov 2025 09:04:30 +0100, Krzysztof Kozlowski <krzk@...nel.org> wrote:

> On Thu, Nov 13, 2025 at 11:50:57PM +0800, Yuntao Wang wrote:
> > This patch series fixes several bugs related to dt_root_addr_cells and
> > dt_root_size_cells, and performs some cleanup.
> >
> > Changelog:
> >
> > v1: Consolidate duplicate code into helper functions
>
> Your patchset has multiple checkpatch warnings and errors. In multiple
> patches.
>
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings. Some warnings can be ignored,
> especially from --strict run, but the code here looks like it needs a
> fix. Feel free to get in touch if the warning is not clear.
>
> Please run standard kernel tools for static analysis, like coccinelle,
> smatch and sparse, and fix reported warnings. Also please check for
> warnings when building with W=1 for gcc and clang. Most of these
> commands (checks or W=1 build) can build specific targets, like some
> directory, to narrow the scope to only your code. The code here looks
> like it needs a fix. Feel free to get in touch if the warning is not
> clear.
>
> Best regards,
> Krzysztof

Hi Krzysztof,

Many thanks for pointing out these issues, they have been fixed in the new patch series:

https://lore.kernel.org/linux-devicetree/20251115134753.179931-1-yuntao.wang@linux.dev/

Thanks,
Yuntao