linux-kernel - Re: [PATCH v1 2/2] dt-bindings: media: i2c: et8ek8: document missing crc as optional property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+hkOd5iAwbKQoNM_qhNc1PpNHw0we3S0J1rFG=W05RnSHR3Bw@mail.gmail.com>
Date: Fri, 14 Nov 2025 16:57:56 -0800
From: Alex Tran <alex.t.tran@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	"Bryan O'Donoghue" <bryan.odonoghue@...aro.org>, Konrad Dybcio <konrad.dybcio@....qualcomm.com>, 
	Hans Verkuil <hverkuil+cisco@...nel.org>, linux-media@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/2] dt-bindings: media: i2c: et8ek8: document missing
 crc as optional property

On Sun, Nov 9, 2025 at 9:18 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On Sat, Nov 08, 2025 at 03:32:00PM -0800, Alex Tran wrote:
> > Add the optional crc property to the endpoint node for the et8ek8 sensor.
> > This property enables CRC checksums for the sensor bus and was added to
> > match the new driver support for reading it from the device tree.
>
> We do not add bindings because you want this in the driver. Please
> describe the hardware.
>
> >
> > Signed-off-by: Alex Tran <alex.t.tran@...il.com>
>
> Your patchser has broken threading. There is no patch #1.
>
> > ---
> >  .../devicetree/bindings/media/i2c/toshiba,et8ek8.txt        | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> > index 8d8e40c56..5fd30f59b 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> > +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> > @@ -30,6 +30,12 @@ Endpoint node mandatory properties
> >  - remote-endpoint: A phandle to the bus receiver's endpoint node.
> >
> >
> > +Endpoint node optional properties
> > +---------------------------------
> > +
> > +- crc: Enable CRC checksums.
>
> Looks like SW property, so not really suitable for bindings.
>
> Also, no changes to TXT bindings are accepted, so first this would have
> to be converted to DT schema.
>
> Best regards,
> Krzysztof
>
Thanks for the review. The et8ek8 sensor has hardware support for CRC
checksums on CCP2.
However, the receiver must also support CRC for this to work.
Whether CRC should be enabled depends on the specific board design and receiver.
Regarding the conversion to a DT schema, I'll follow up with a patch
series v2 that fixes the broken threading and converts the binding to
a YAML format.

Best,
--
Alex Tran