linux-kernel - Re: [PATCH v4 03/10] uaccess: Use masked_user_{read/write}_access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87h5uv9ts5.ffs@tglx>
Date: Sat, 15 Nov 2025 16:53:30 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Christophe Leroy <christophe.leroy@...roup.eu>, Alexander Viro
 <viro@...iv.linux.org.uk>, Christian Brauner <brauner@...nel.org>, Jan
 Kara <jack@...e.cz>, Ingo Molnar <mingo@...hat.com>, Peter Zijlstra
 <peterz@...radead.org>, Darren Hart <dvhart@...radead.org>, Davidlohr
 Bueso <dave@...olabs.net>, Andre Almeida <andrealmeid@...lia.com>, Andrew
 Morton <akpm@...ux-foundation.org>, Eric Dumazet <edumazet@...gle.com>,
 Kuniyuki Iwashima <kuniyu@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Willem de Bruijn <willemb@...gle.com>, "David S. Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Simon Horman
 <horms@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Dave Hansen
 <dave.hansen@...ux.intel.com>, Madhavan Srinivasan <maddy@...ux.ibm.com>,
 Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>
Cc: Christophe Leroy <christophe.leroy@...roup.eu>,
 linux-block@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v4 03/10] uaccess: Use
 masked_user_{read/write}_access_begin when required

On Thu, Nov 06 2025 at 12:31, Christophe Leroy wrote:
> diff --git a/net/core/scm.c b/net/core/scm.c
> index 66eaee783e8be..4a65f9baa87e7 100644
> --- a/net/core/scm.c
> +++ b/net/core/scm.c
> @@ -274,7 +274,7 @@ int put_cmsg(struct msghdr * msg, int level, int type, int len, void *data)
>  		check_object_size(data, cmlen - sizeof(*cm), true);
>  
>  		if (can_do_masked_user_access())
> -			cm = masked_user_access_begin(cm);
> +			cm = masked_user_write_access_begin(cm);
>  		else if (!user_write_access_begin(cm, cmlen))
>  			goto efault;

Shouldn't this be converted to scoped_....() ?