linux-kernel - Re: [PATCH] lockdep: Add header and footer to surround warning reports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVL=0u0-1GtVyrf_uYadNf3L9Y8a8zemzVwU1SnNV5x8A@mail.gmail.com>
Date: Sat, 15 Nov 2025 17:36:43 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Tzung-Bi Shih <tzungbi@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Will Deacon <will@...nel.org>, Boqun Feng <boqun.feng@...il.com>, Waiman Long <longman@...hat.com>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lockdep: Add header and footer to surround warning reports

Hi Tzung-Bi,

On Fri, 14 Nov 2025 at 07:35, Tzung-Bi Shih <tzungbi@...nel.org> wrote:
> Add header and footer to improve log parsing and automated analysis.
> This makes lockdep output easier to interpret.
>
> Signed-off-by: Tzung-Bi Shih <tzungbi@...nel.org>

Thanks for your patch!

> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -1958,6 +1964,7 @@ print_circular_bug_header(struct lock_list *entry, unsigned int depth,
>                 return;
>
>         pr_warn("\n");
> +       pr_warn(CUT_HERE);
>         pr_warn("======================================================\n");

I guess you can drop all lines printing a separator made of equal signs,
as CUT_HERE already contains a graphical separator.

>         pr_warn("WARNING: possible circular locking dependency detected\n");
>         print_kernel_ident();

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds