linux-kernel - Re: [PATCH v1 0/3] iio: core: fix error path in iio_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251115172930.3b06d771@jic23-huawei>
Date: Sat, 15 Nov 2025 17:29:30 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Nuno Sá <noname.nuno@...il.com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Jonathan Cameron 
 <Jonathan.Cameron@...wei.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, David Lechner <dlechner@...libre.com>, Nuno
 Sá	 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>
Subject: Re: [PATCH v1 0/3] iio: core: fix error path in iio_device_alloc()

On Wed, 12 Nov 2025 18:00:42 +0000
Nuno Sá <noname.nuno@...il.com> wrote:

> On Wed, 2025-11-12 at 15:55 +0100, Andy Shevchenko wrote:
> > The series is induced by the similar fixes in viio_trigger_alloc().
> > Basically two things happen here: 1) add missed mutex_destroy()
> > calls, and 2) refactor to make sure we clean resources with put_device()
> > when appropriate.
> > 
> > Andy Shevchenko (3):
> >   iio: core: add missing mutex_destroy in iio_dev_release()
> >   iio: core: Clean up device correctly on iio_device_alloc() failure
> >   iio: core: Replace lockdep_set_class() + mutex_init() by combined call
> > 
> >  drivers/iio/industrialio-core.c | 18 +++++++++++-------
> >  1 file changed, 11 insertions(+), 7 deletions(-)  
> 
> LGTM,
> 
> Reviewed-by: Nuno Sá <nuno.sa@...log.com>
> 
I'm not going to rush these in given where we are in the cycle
and the fact only some are fixes (and really no one cares that
much about mutex_destroy() as it only does anything at all in
a particular debug setup.)

So applied to the togreg branch of iio.git and pushed out as testing
for now.

Thanks,

Jonathan