linux-kernel - Re: [PATCH v4 0/3] iio: mpl3115: support for events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251115180742.75ea99f6@jic23-huawei>
Date: Sat, 15 Nov 2025 18:07:42 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Antoni Pokusinski <apokusinski01@...il.com>
Cc: dlechner@...libre.com, nuno.sa@...log.com, andy@...nel.org,
 marcelo.schmitt1@...il.com, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/3] iio: mpl3115: support for events

On Wed, 12 Nov 2025 23:56:58 +0100
Antoni Pokusinski <apokusinski01@...il.com> wrote:

> Hello,
> The mpl3115 device can raise interrupts when a pressure or temperature
> threshold is crossed, this patchset adds support for them using IIO's
> events interface.
> 
> In v4 mostly some minor variable rename changes and a comment in
> read_info_raw according to the review in v3.
Looks good to me, thanks.

Applied to the togreg branch of iio.git but initially pushed out as
testing to let the build bots poke at it and see if they can find
anything we missed.

Thanks,

Jonathan

> 
> Kind regards,
> Antoni Pokusinski
> 
> ---
> Changes since v3:
> (patch 1/3 "use get_unaligned_be24() to retrieve pressure data")
> * commit msg: "get_unaligned_be24" -> "get_unaligned_be24()"
> * read_info_raw: renamed "tmp[3]" -> "press_be24[3]"
> * read_info_raw: added comment at pressure val computation
> (patch 2/3 "add threshold support")
> * interrupt_handler: added sizeof() in a i2c_read_i2c_block call
> * read_thresh: renamed "tmp" -> "press_tgt"
> * write_thresh: renamed "tmp" -> "press_tgt"
> 
> Changes since v2:
> (general)
> * added the patch tidying up the pressure data retrieval (u8[3] used)
> (patch 2/3 "add threshold support")
> * includes: removed unused linux/units.h
> * read_thresh: fixed comment formatting
> * interrupt_handler: val_press is now u8[3] instead of __be32
> 
> Changes since v1:
> (general)
> * squashed the cleanup patch
> * added the patch with the documentation update
> (patch 1/2 "add threshold event support")
> * patch description: explained changes in locking
> * read_event_config: replaced switch with ifs
> * read_event_config: return as early as possible, got rid of int_en_mask
> * read/write_thresh: pressure: calculation changes to comply with raw ABI
> * interrupt_handler: reordered the INT_SRC_* bits in if condition
> * read/write_thresh: used sizeof() and values from limits.h
> * write_thresh: replaced `u8 tmp[2]` with `__be16 tmp`
> * dropped the space between casting `(u8 *) &tmp`
> 
> 
> Antoni Pokusinski (3):
>   iio: mpl3115: use get_unaligned_be24() to retrieve pressure data
>   iio: mpl3115: add threshold events support
>   iio: ABI: document pressure event attributes
> 
>  Documentation/ABI/testing/sysfs-bus-iio |   2 +
>  drivers/iio/pressure/mpl3115.c          | 234 ++++++++++++++++++++++--
>  2 files changed, 223 insertions(+), 13 deletions(-)
> 
> 
> base-commit: 1d09cf18cc91d29f650ad9811ed4868d9304d6c7