linux-kernel - Re: [PATCH v1 1/1] iio: imu: inv_icm42600: Convert to uXX and sXX integer types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251115185001.01f2b148@jic23-huawei>
Date: Sat, 15 Nov 2025 18:50:01 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>, Jean-Baptiste Maneyrol
 <jean-baptiste.maneyrol@....com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, David Lechner <dlechner@...libre.com>, Nuno
 Sá <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>
Subject: Re: [PATCH v1 1/1] iio: imu: inv_icm42600: Convert to uXX and sXX
 integer types

On Sun,  9 Nov 2025 20:24:36 +0100
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> The driver code is full of intXX_t and uintXX_t types which is
> not the pattern we use in the IIO subsystem. Switch the driver
> to use kernel internal types for that. No functional changes.
No problem with the change but this description made me think
that this was going to be a huge patch touching lots of instances.

Probably needs a rewrite to not say 'full of' :)
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> 
> Jonathan, what is the status of fixing the type for
> iio_push_to_buffers_with_timestamp()? This patch doesn't do that
> as I see no API has been fixed (and it seems the only one that uses
> the *intXX_t parameter).
> 
>  drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c b/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c
> index 54760d8f92a2..9be5ade24501 100644
> --- a/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c
> +++ b/drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c
> @@ -1209,7 +1209,7 @@ int inv_icm42600_accel_parse_fifo(struct iio_dev *indio_dev)
>  	ssize_t i, size;
>  	unsigned int no;
>  	const void *accel, *gyro, *timestamp;
> -	const int8_t *temp;
> +	const s8 *temp;
>  	unsigned int odr;
>  	int64_t ts_val;
>  	/* buffer is copied to userspace, zeroing it to avoid any data leak */