linux-kernel - Re: [PATCH v5 13/13] gpu: nova-core: gsp: Retrieve GSP static info to gather GPU information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59592581-b6de-4883-a6ef-06358d7b6606@nvidia.com>
Date: Sat, 15 Nov 2025 13:03:32 -0800
From: John Hubbard <jhubbard@...dia.com>
To: Alexandre Courbot <acourbot@...dia.com>,
 Joel Fernandes <joelagnelf@...dia.com>, linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 Danilo Krummrich <dakr@...nel.org>
Cc: Alistair Popple <apopple@...dia.com>, Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>, bjorn3_gh@...tonmail.com,
 Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Timur Tabi <ttabi@...dia.com>, joel@...lfernandes.org,
 Daniel Almeida <daniel.almeida@...labora.com>,
 nouveau@...ts.freedesktop.org,
 Nouveau <nouveau-bounces@...ts.freedesktop.org>
Subject: Re: [PATCH v5 13/13] gpu: nova-core: gsp: Retrieve GSP static info to
 gather GPU information

On 11/15/25 4:38 AM, Alexandre Courbot wrote:
> This one needed some rework.
> 
> On Sat Nov 15, 2025 at 4:55 AM JST, Joel Fernandes wrote:
>> From: Alistair Popple <apopple@...dia.com>
...
>> +pub(crate) struct GspStaticConfigInfo {
>> +    pub gpu_name: [u8; 40],
> 
> This is probably meant to be `0x40`, as the `gpuNameString` bindings
> member this is built from is 64-bytes long. Changing it to be 64-bytes
> long.

Oh yes. The 40 actually resurrects an old bug that I had fixed once,
because it truncates the very long and elaborate Blackwell GB200
card's name that I am testing with.

Good catch!


thanks,
-- 
John Hubbard