linux-kernel - Re: [PATCH net] net: openvswitch: remove never-working support for setting nsh fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <176317321200.1911668.558293719970758983.git-patchwork-notify@kernel.org>
Date: Sat, 15 Nov 2025 02:20:12 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Ilya Maximets <i.maximets@....org>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
 linux-kernel@...r.kernel.org, dev@...nvswitch.org, echaudro@...hat.com,
 aconole@...hat.com, w@....eu, kwqcheii@...ton.me, zhuque@...cent.com
Subject: Re: [PATCH net] net: openvswitch: remove never-working support for
 setting nsh fields

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 12 Nov 2025 12:14:03 +0100 you wrote:
> The validation of the set(nsh(...)) action is completely wrong.
> It runs through the nsh_key_put_from_nlattr() function that is the
> same function that validates NSH keys for the flow match and the
> push_nsh() action.  However, the set(nsh(...)) has a very different
> memory layout.  Nested attributes in there are doubled in size in
> case of the masked set().  That makes proper validation impossible.
> 
> [...]

Here is the summary with links:
  - [net] net: openvswitch: remove never-working support for setting nsh fields
    https://git.kernel.org/netdev/net/c/dfe28c4167a9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html