linux-kernel - Re: [PATCH] spi: bcm63xx: drop wrong casts in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ea87b04d-a7a3-4e2d-855e-808999a5f659@broadcom.com>
Date: Sun, 16 Nov 2025 09:15:29 -0800
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Jonas Gorski <jonas.gorski@...il.com>, Mark Brown <broonie@...nel.org>,
 Grant Likely <grant.likely@...retlab.ca>,
 Tanguy Bouzeloc <tanguy.bouzeloc@...xo.com>
Cc: linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: bcm63xx: drop wrong casts in probe()



On 11/16/2025 1:33 AM, Jonas Gorski wrote:
> Both bs->regs and bs->{rx,tx}_io are tagged __iomem, so we shouldn't
> cast them to anything else.
> 
> Silences the following sparse warning:
> 
> drivers/spi/spi-bcm63xx.c:571:22: warning: cast removes address space '__iomem' of expression
> drivers/spi/spi-bcm63xx.c:571:19: warning: incorrect type in assignment (different address spaces)
> drivers/spi/spi-bcm63xx.c:571:19:    expected unsigned char [noderef] [usertype] __iomem *tx_io
> drivers/spi/spi-bcm63xx.c:571:19:    got unsigned char [usertype] *
> drivers/spi/spi-bcm63xx.c:572:22: warning: cast removes address space '__iomem' of expression
> drivers/spi/spi-bcm63xx.c:572:19: warning: incorrect type in assignment (different address spaces)
> drivers/spi/spi-bcm63xx.c:572:19:    expected unsigned char const [noderef] [usertype] __iomem *rx_io
> drivers/spi/spi-bcm63xx.c:572:19:    got unsigned char const [usertype] *
> 
> Fixes: b42dfed83d95 ("spi: add Broadcom BCM63xx SPI controller driver")
> Signed-off-by: Jonas Gorski <jonas.gorski@...il.com>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>

Not sure that deserves a Fixes, tag, but can't hurt!
-- 
Florian