linux-kernel - Re: [PATCH] tools: riscv: Fixed misalignment of CSR related definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <421f4746-8d75-227b-6459-bbd82dfd6fa9@kernel.org>
Date: Sun, 16 Nov 2025 10:22:34 -0700 (MST)
From: Paul Walmsley <pjw@...nel.org>
To: Chen Pei <cp0613@...ux.alibaba.com>
cc: anup@...infault.org, atish.patra@...ux.dev, pjw@...nel.org, 
    haibo1.xu@...el.com, guoren@...nel.org, linux-riscv@...ts.infradead.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools: riscv: Fixed misalignment of CSR related
 definitions

Hi, 

On Fri, 14 Nov 2025, cp0613@...ux.alibaba.com wrote:

> From: Chen Pei <cp0613@...ux.alibaba.com>
> 
> The file tools/arch/riscv/include/asm/csr.h borrows from
> arch/riscv/include/asm/csr.h, and subsequent modifications
> related to CSR should maintain consistency.

Thanks for the patch.  A few comments:

> Fixes: 16b0bde9a37c ("RISC-V: KVM: Add perf sampling support for guests")
> Fixes: d1927f64e0e1 ("RISC-V: Fix the typo in Scountovf CSR name")

It seems like this is pushing the definition of "fixes" here.  It looks 
like the only thing wrong with those patches is that they didn't change 
the files under tools/. right?  It would have been nice if they had 
included the changes to files under tools/, but since the patches don't 
introduce any bugs directly, I don't think we should include these Fixes: 
lines here.

>
> Signed-off-by: Chen Pei <cp0613@...ux.alibaba.com>

Please, no blank line between the Fixes: headers and the Signed-off-by:.

I've removed the Fixes: lines and the superfluous blank line, and queued 
this for v6.18-rc fixes.

- Paul