linux-kernel - Re: [PATCH 1/2] arm64: dts: qcom: rubikpi3: Add qcs6490-rubikpi3 board dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <qirvwqob65x34yytw4warziotqfdas5bqjkbwfiighev7czz6f@zpofwqcznfwv>
Date: Sun, 16 Nov 2025 19:46:33 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Hongyang Zhao <hongyang.zhao@...ndersoft.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Roger Shimizu <rosh@...ian.org>
Subject: Re: [PATCH 1/2] arm64: dts: qcom: rubikpi3: Add qcs6490-rubikpi3
 board dts

On Sat, Nov 15, 2025 at 12:34:15AM +0800, Hongyang Zhao wrote:
> Add DTS for Thundercomm qcs6490-rubikpi3 board which uses
> QCS6490 SoC.
> 
> Works:
> - Bluetooth (AP6256)
> - Wi-Fi (AP6256)
> - Ethernet (AX88179B connected to UPD720201)
> - FAN
> - Two USB Type-A 3.0 ports (UPD720201 connected to PCIe0)
> - M.2 M-Key 2280 PCIe 3.0
> - RTC
> - USB Type-C
> - USB Type-A 2.0 port
> - 40PIN: I2C x1, UART x1
> 
> Signed-off-by: Hongyang Zhao <hongyang.zhao@...ndersoft.com>
> Reviewed-by: Roger Shimizu <rosh@...ian.org>
> ---
>  arch/arm64/boot/dts/qcom/Makefile                  |    1 +
>  .../boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dts | 1415 ++++++++++++++++++++
>  2 files changed, 1416 insertions(+)
> 
> +&pcie1 {
> +	/* Using traditional address mapping */
> +	reg = <0 0x01c08000 0 0x3000>,
> +	      <0 0x40000000 0 0xf1d>,
> +	      <0 0x40000f20 0 0xa8>,
> +	      <0 0x40001000 0 0x1000>,
> +	      <0 0x40100000 0 0x100000>;
> +
> +	ranges = <0x01000000 0x0 0x00000000 0x0 0x40200000 0x0 0x100000>,
> +		 <0x02000000 0x0 0x40300000 0x0 0x40300000 0x0 0x1fd00000>;

No. Don't workaround bugs in kodiak.dtsi in your DT file. Please fix it
in kodiak.dtsi instead.

> +
> +
> +	perst-gpios = <&tlmm 2 GPIO_ACTIVE_LOW>;
> +	wake-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>;
> +
> +	pinctrl-0 = <&pcie1_clkreq_n>,
> +		    <&pcie1_reset_n>,
> +		    <&pcie1_wake_n>;
> +	pinctrl-names = "default";
> +
> +	status = "okay";
> +};
> +

-- 
With best wishes
Dmitry