linux-kernel - Re: [PATCH 0/2] rbree: inline rb_first() and rb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iKYLf1AWi_YvK47NvQXb0B31NHxF736dXYg=2E5Xxg0Ew@mail.gmail.com>
Date: Sun, 16 Nov 2025 10:41:31 -0800
From: Eric Dumazet <edumazet@...gle.com>
To: Kuan-Wei Chiu <visitorckw@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, linux-kernel <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org, 
	Neal Cardwell <ncardwell@...gle.com>, Kuniyuki Iwashima <kuniyu@...gle.com>, 
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH 0/2] rbree: inline rb_first() and rb_last()

On Sun, Nov 16, 2025 at 10:00 AM Kuan-Wei Chiu <visitorckw@...il.com> wrote:
>
> Hi Eric,
>
> On Fri, Nov 14, 2025 at 02:06:44PM +0000, Eric Dumazet wrote:
> > Inline these two small helpers, heavily used in TCP and FQ packet scheduler,
> > and in many other places.
> >
> > This reduces kernel text size, and brings an 1.5 % improvement on network
> > TCP stress test.
>
> Thanks for the patch!
>
> Just out of curiosity, do you think rb_first() and rb_last() would be
> worth marking with __always_inline?

I have not seen any difference, what compilers are you using that
would not inline this ?