linux-kernel - Re: [PATCH net-next v4 5/5] selftests: netconsole: validate target resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vt5igunw47u726ty5romoycbibjbbjgtv5cz53cyq2uh6mtnw7@dvehioj2kkiw>
Date: Sun, 16 Nov 2025 18:59:43 +0000
From: Andre Carvalho <asantostc@...il.com>
To: Breno Leitao <leitao@...ian.org>, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>, 
	Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next v4 5/5] selftests: netconsole: validate target
 resume

On Sun, Nov 16, 2025 at 05:14:05PM +0000, Andre Carvalho wrote:
> +	pkill_socat
> +	# Cleanup & unload the module
> +	cleanup
> +	trap - EXIT

I noticed a small mistake here. This trap line should be outside of the loop,
right before exit. I'll send v5 fixing this after the 24h cooldown period.

> +
> +	echo "${BINDMODE} : Test passed" >&2
> +done
> +
> +exit "${ksft_pass}"
> 
> -- 
> 2.51.2
> 

-- 
Andre Carvalho