linux-kernel - Re: [PATCH v5] rust: rbtree: add immutable cursor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72mamgCYRGSQyYb-vB4sPuK+9RrMOrEmJr-hkGzTAueQ_Q@mail.gmail.com>
Date: Sun, 16 Nov 2025 23:34:00 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Vitaly Wool <vitaly.wool@...sulko.se>
Cc: rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Danilo Krummrich <dakr@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Bjorn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Trevor Gross <tmgross@...ch.edu>, Onur Özkan <work@...rozkan.dev>
Subject: Re: [PATCH v5] rust: rbtree: add immutable cursor

On Tue, Oct 14, 2025 at 2:33 PM Vitaly Wool <vitaly.wool@...sulko.se> wrote:
>
> +                    best_links = Some(unsafe { NonNull::new_unchecked(&mut (*this).links) });

Is there a reason this kind of borrow is a `&mut` and not a `&raw mut`?

I see in the same file there are others that could be simplified too.

Cheers,
Miguel